From: David Miller <davem@davemloft.net>
To: maowenan@huawei.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
arvid.brodin@alten.se
Subject: Re: [PATCH net] net: hsr: fix memory leak in hsr_dev_finalize()
Date: Wed, 06 Mar 2019 10:57:32 -0800 (PST) [thread overview]
Message-ID: <20190306.105732.1611262774925888075.davem@davemloft.net> (raw)
In-Reply-To: <20190306144501.77976-1-maowenan@huawei.com>
From: Mao Wenan <maowenan@huawei.com>
Date: Wed, 6 Mar 2019 22:45:01 +0800
> If hsr_add_port(hsr, hsr_dev, HSR_PT_MASTER) failed to
> add port, it directly returns res and forgets to free the node
> that allocated in hsr_create_self_node(), and forgets to delete
> the node->mac_list linked in hsr->self_node_db.
...
> Fixes: c5a759117210("net/hsr: Use list_head (and rcu) instead of array for slave devices.")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-03-06 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 14:45 [PATCH net] net: hsr: fix memory leak in hsr_dev_finalize() Mao Wenan
2019-03-06 18:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306.105732.1611262774925888075.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arvid.brodin@alten.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).