From: Thomas Haller <thaller@redhat.com>
To: netdev@vger.kernel.org
Cc: stephen@networkplumber.org, Thomas Haller <thaller@redhat.com>
Subject: [PATCH iproute2] iprule: fix printing hint about unresolved iifname and oifname
Date: Wed, 6 Mar 2019 12:04:00 +0100 [thread overview]
Message-ID: <20190306110400.25252-1-thaller@redhat.com> (raw)
# ip rule add priority 10 iif eth1 goto 10000 protocol 10
was displayed as
10: from all iif eth1 [detached] goto 10000unresolved proto mrt
now:
10: from all iif eth1 [detached] goto 10000 [unresolved] proto mrt
Fixes: 0dd4ccc56c0e ("iprule: add json support")
Signed-off-by: Thomas Haller <thaller@redhat.com>
---
ip/iprule.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iprule.c b/ip/iprule.c
index 4e9437de..0bd4c636 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -455,7 +455,7 @@ int print_rule(struct nlmsghdr *n, void *arg)
print_string(PRINT_ANY, "goto", "goto %s", "none");
if (frh->flags & FIB_RULE_UNRESOLVED)
- print_null(PRINT_ANY, "unresolved", "unresolved", NULL);
+ print_null(PRINT_ANY, "unresolved", " [unresolved]", NULL);
} else if (frh->action == FR_ACT_NOP) {
print_null(PRINT_ANY, "nop", "nop", NULL);
} else if (frh->action != FR_ACT_TO_TBL) {
--
2.20.1
reply other threads:[~2019-03-06 11:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306110400.25252-1-thaller@redhat.com \
--to=thaller@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).