RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

Parav Pandit
2019-03-18T19:38:48Z

> -----Original Message-----
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Sent: Monday, March 18, 2019 2:19 PM
> To: Jiri Pirko <jiri@resnulli.us>
> Cc: Parav Pandit <parav@mellanox.com>; Samudrala, Sridhar
> <sridhar.samudrala@intel.com>; davem@davemloft.net;
> netdev@vger.kernel.org; oss-drivers@netronome.com
> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI
> ports
>
> On Mon, 18 Mar 2019 13:21:05 +0100, Jiri Pirko wrote:
> > >First two entries shows the link between hostport and switchport.
> > >$ devlink port show
> > >pci/0000:05:00.0/10002 eth netdev flavour switchport switch_id
> 00154d130d2f peer pci/0000:05:00.0/1
> > >
> > >pci/0000:05:00.0/1 eth netdev flavour hostport switch_id 00154d130d2f
> peer pci/0000:05:00.0/10002
> >
> > Hostport should not have switch_id.
>
> Isn't a concept of a port of a switch without a switch ID a red flag?
It shows that a given hostport is connected to a given switchid at given switchport.
But I believe this info can be dropped, because this is visible at the switchport side.
So when showing hostport, it can be just only,

pci/0000:05:00.0/1 eth netdev flavour hostport