Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

Jiri Pirko
2019-03-21T09:20:09Z

Mon, Mar 18, 2019 at 08:19:00PM CET, jakub.kicinski@netronome.com wrote:
>On Mon, 18 Mar 2019 13:21:05 +0100, Jiri Pirko wrote:
>> >First two entries shows the link between hostport and switchport.
>> >$ devlink port show
>> >pci/0000:05:00.0/10002 eth netdev flavour switchport switch_id 00154d130d2f peer pci/0000:05:00.0/1
>> >
>> >pci/0000:05:00.0/1 eth netdev flavour hostport switch_id 00154d130d2f peer pci/0000:05:00.0/10002
>>
>> Hostport should not have switch_id.
>
>Isn't a concept of a port of a switch without a switch ID a red flag?

If we want to have hostports as devlink ports, they should not have
switch id. They are not switch ports but rather counterparts of the
switch ports.