From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6E1C43381 for ; Wed, 6 Mar 2019 19:33:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 614A420657 for ; Wed, 6 Mar 2019 19:33:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729579AbfCFTdW (ORCPT ); Wed, 6 Mar 2019 14:33:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51310 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726313AbfCFTdW (ORCPT ); Wed, 6 Mar 2019 14:33:22 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD52659463; Wed, 6 Mar 2019 19:33:21 +0000 (UTC) Received: from localhost (ovpn-200-28.brq.redhat.com [10.40.200.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 785A01001DE2; Wed, 6 Mar 2019 19:33:19 +0000 (UTC) Date: Wed, 6 Mar 2019 20:33:13 +0100 From: Stefano Brivio To: Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet , syzbot , Sabrina Dubroca Subject: Re: [PATCH net] fou, fou6: avoid uninit-value in gue_err() and gue6_err() Message-ID: <20190306203313.60c413a3@redhat.com> In-Reply-To: <20190306184100.190813-1-edumazet@google.com> References: <20190306184100.190813-1-edumazet@google.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 06 Mar 2019 19:33:21 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 6 Mar 2019 10:41:00 -0800 Eric Dumazet wrote: > My prior commit missed the fact that these functions > were using udp_hdr() (aka skb_transport_header()) > to get access to GUE header. Ouch, I totally missed this too. :/ > Since use pskb_transport_may_pull() does not exist yet, Nit: s/use // > we have to add transport_offset to our pskb_may_pull() calls. Thanks for fixing this. Acked-by: Stefano Brivio -- Stefano