From: Stephen Hemminger <stephen@networkplumber.org>
To: Brodie Greenfield <brodie.greenfield@alliedtelesis.co.nz>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, chris.packham@alliedtelesis.co.nz,
luuk.paulussen@alliedtelesis.co.nz
Subject: Re: [PATCH 1/2] ipmr: Make cache queue length configurable
Date: Thu, 7 Mar 2019 07:40:29 -0800 [thread overview]
Message-ID: <20190307074029.3f1f0c28@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190306201956.30248-2-brodie.greenfield@alliedtelesis.co.nz>
On Thu, 7 Mar 2019 09:19:55 +1300
Brodie Greenfield <brodie.greenfield@alliedtelesis.co.nz> wrote:
> +ip_mr_cache_queue_length - INTEGER
> + Limit the number of multicast packets we can have in the queue to be
> + resolved.
> + Bear in mind that when an unresolved multicast packet is received,
> + there is an O(n) traversal of the queue. This should be considered
> + if increasing.
> +
Why not make it to a unsigned value? A negative value doesn't make
much sense here.
Although other sysctl values date back to a time when Linux was
sloppy about allowing negative values, it would be good to use unsigned
now.
next prev parent reply other threads:[~2019-03-07 15:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 20:19 [PATCH 0/2] Make ipmr queue length configurable Brodie Greenfield
2019-03-06 20:19 ` [PATCH 1/2] ipmr: Make cache " Brodie Greenfield
2019-03-07 15:40 ` Stephen Hemminger [this message]
2019-03-06 20:19 ` [PATCH 2/2] ip6mr: " Brodie Greenfield
2019-03-06 20:25 ` Chris Packham
-- strict thread matches above, loose matches on Subject: below --
2019-03-07 4:57 [PATCH 0/2] Make ipmr " Brodie Greenfield
2019-03-07 4:57 ` [PATCH 1/2] ipmr: Make cache " Brodie Greenfield
2019-07-25 20:42 [PATCH 0/2] Make ipmr " Brodie Greenfield
2019-07-25 20:42 ` [PATCH 1/2] ipmr: Make cache " Brodie Greenfield
2019-07-26 10:10 ` Stephen Suryaputra
2019-07-26 11:05 ` Nikolay Aleksandrov
2019-07-26 11:15 ` Nikolay Aleksandrov
2019-07-27 17:03 ` Stephen Suryaputra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307074029.3f1f0c28@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=brodie.greenfield@alliedtelesis.co.nz \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=luuk.paulussen@alliedtelesis.co.nz \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox