From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=S1r7=RL=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D194AC43381
	for <netdev@archiver.kernel.org>; Fri,  8 Mar 2019 23:20:50 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id A4F822064A
	for <netdev@archiver.kernel.org>; Fri,  8 Mar 2019 23:20:50 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726435AbfCHXUt (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 8 Mar 2019 18:20:49 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:41430 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726111AbfCHXUs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 8 Mar 2019 18:20:48 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 2B6711480D4F0;
        Fri,  8 Mar 2019 15:20:48 -0800 (PST)
Date:   Fri, 08 Mar 2019 15:20:47 -0800 (PST)
Message-Id: <20190308.152047.1195514192232119769.davem@davemloft.net>
To:     edumazet@google.com
Cc:     netdev@vger.kernel.org, eric.dumazet@gmail.com,
        syzkaller@googlegroups.com, sbrivio@redhat.com, sd@queasysnail.net
Subject: Re: [PATCH net] fou, fou6: avoid uninit-value in gue_err() and
 gue6_err()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190306184100.190813-1-edumazet@google.com>
References: <20190306184100.190813-1-edumazet@google.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Mar 2019 15:20:48 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Eric Dumazet <edumazet@google.com>
Date: Wed,  6 Mar 2019 10:41:00 -0800

> My prior commit missed the fact that these functions
> were using udp_hdr() (aka skb_transport_header())
> to get access to GUE header.
> 
> Since use pskb_transport_may_pull() does not exist yet,
> we have to add transport_offset to our pskb_may_pull() calls.
 ...
> Fixes: 26fc181e6cac ("fou, fou6: do not assume linear skbs")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>

Applied and queued up for -stable, thanks Eric.