From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9DCC43381 for ; Fri, 8 Mar 2019 17:02:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF298204FD for ; Fri, 8 Mar 2019 17:02:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mdKE1s4o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbfCHRCZ (ORCPT ); Fri, 8 Mar 2019 12:02:25 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:33010 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbfCHRCY (ORCPT ); Fri, 8 Mar 2019 12:02:24 -0500 Received: by mail-qt1-f194.google.com with SMTP id z39so21979429qtz.0; Fri, 08 Mar 2019 09:02:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+DAyM84XzxRMe+1+3FE/9ysBPH35KoA/oVz4R2kcukY=; b=mdKE1s4ou8EJKn6Fep5ncEn6h5OmtLJhs5NLWEWLJoyHsr1DdNN90GYCGBPZPv6uw1 V6tgm2kMEXaa89El99fukqVAYQiY5oGVBXUDEldutpRzd5EglVywZryPGeRCDh4aAXe5 gfwuzSp0pJ5JgX1I5Nx1/ua98dWhnrsB76VD5ujc6lViZ3qH/neb8HKmGCY9F3z9Fxa8 K1jGj6yQMHjKZ2MkmSaXXi7HHNcda3JtkQ1O+Rxl5/hFjN0sbmYdP0JktUFgDpReL7BM QkcaXHIf2nyxs6vGEEl6LUA1HqrkDLL89F6gHlwX5Lp3F0+a2VgMdKwZTSWQYVny5hRK bKUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+DAyM84XzxRMe+1+3FE/9ysBPH35KoA/oVz4R2kcukY=; b=PsuYhqGzSH9VwhnrvDB6xEhkdMHKzhVZ7UajIKqa+sc+unzKu3jeBnyttfHjCXYTbA jCIaxIPDWYk7/4hLS+xSRQJzBp1zPJ+pCrVGak0dNrNc9bEMUfWPvG+mb5FhlQkdkGD+ ry33Z6VPJeLw0oEXJsy+3ypYtidVtIZIM6jPmqWdtDmWrPQnrZ2vOzhOGOCfFb+owMzP 2Srdx6gFhyUOu40gfOcrWL0NGfdmMpJGtOYSei7DDTp6yLGMRQscQae7GkIkfe0n+hEn 6TlSgCEZmhSeYl5Znj4dKwav58A5zmpR/LpgcstzO4WpLPRY9RsgmqcWGgcDLlYoiS0W 4H6g== X-Gm-Message-State: APjAAAXUwIBI/swOR2xyjk5oIDOgNZ52Nre0LaWLnpOu9/VDyDpXPJw1 hx7Rj7FSu/szrXUoZX3imok= X-Google-Smtp-Source: APXvYqyykCxhgk7SRs0oGtqEOBLMRjD5TAgeNS5cdd88/g9kpez4JlsbkVcSnC9IWgVq7IqM/uiORw== X-Received: by 2002:ac8:2f77:: with SMTP id k52mr15635139qta.271.1552064543595; Fri, 08 Mar 2019 09:02:23 -0800 (PST) Received: from localhost.localdomain ([168.181.49.39]) by smtp.gmail.com with ESMTPSA id j17sm1949357qtj.61.2019.03.08.09.02.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Mar 2019 09:02:22 -0800 (PST) Received: by localhost.localdomain (Postfix, from userid 1000) id 77144180BE0; Fri, 8 Mar 2019 14:02:20 -0300 (-03) Date: Fri, 8 Mar 2019 14:02:20 -0300 From: Marcelo Ricardo Leitner To: Neil Horman Cc: Xin Long , network dev , linux-sctp@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH net] sctp: remove sched init from sctp_stream_init Message-ID: <20190308170220.GE13515@localhost.localdomain> References: <20190308122136.GA982@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190308122136.GA982@hmswarspite.think-freely.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 08, 2019 at 07:21:36AM -0500, Neil Horman wrote: > On Fri, Mar 08, 2019 at 03:49:16PM +0800, Xin Long wrote: > > syzbot reported a NULL-ptr deref caused by that sched->init() in > > sctp_stream_init() set stream->rr_next = NULL. > > > > kasan: GPF could be caused by NULL-ptr deref or user memory access > > RIP: 0010:sctp_sched_rr_dequeue+0xd3/0x170 net/sctp/stream_sched_rr.c:141 > > Call Trace: > > sctp_outq_dequeue_data net/sctp/outqueue.c:90 [inline] > > sctp_outq_flush_data net/sctp/outqueue.c:1079 [inline] > > sctp_outq_flush+0xba2/0x2790 net/sctp/outqueue.c:1205 > > > > All sched info is saved in sout->ext now, in sctp_stream_init() > > sctp_stream_alloc_out() will not change it, there's no need to > > call sched->init() again, since sctp_outq_init() has already > > done it. through sctp_sched_set_sched(), yes. Thanks Xin. Acked-by: Marcelo Ricardo Leitner > > > > Fixes: 5bbbbe32a431 ("sctp: introduce stream scheduler foundations") > > Reported-by: syzbot+4c9934f20522c0efd657@syzkaller.appspotmail.com > > Signed-off-by: Xin Long > > --- > > net/sctp/stream.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/net/sctp/stream.c b/net/sctp/stream.c > > index 2936ed1..3b47457 100644 > > --- a/net/sctp/stream.c > > +++ b/net/sctp/stream.c > > @@ -230,8 +230,6 @@ int sctp_stream_init(struct sctp_stream *stream, __u16 outcnt, __u16 incnt, > > for (i = 0; i < stream->outcnt; i++) > > SCTP_SO(stream, i)->state = SCTP_STREAM_OPEN; > > > > - sched->init(stream); > > - > > in: > > sctp_stream_interleave_init(stream); > > if (!incnt) > > -- > > 2.1.0 > > > > > Acked-by: Neil Horman >