From: Guillaume Nault <gnault@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] tcp: handle inet_csk_reqsk_queue_add() failures
Date: Sat, 9 Mar 2019 10:02:35 +0100 [thread overview]
Message-ID: <20190309090234.GA29222@pc-2.home> (raw)
In-Reply-To: <69908e11-c7c7-b0aa-0382-618bae4e4572@gmail.com>
On Fri, Mar 08, 2019 at 03:47:25PM -0800, Eric Dumazet wrote:
>
> On 03/08/2019 02:40 PM, Guillaume Nault wrote:
> > On Fri, Mar 08, 2019 at 02:34:07PM -0800, Eric Dumazet wrote:
> >
> > Long term, do we want to keep the WARN_ON_ONCE()? If so, we should
> > probably remove the comment.
>
> We want to keep the warning.
>
> We do not have a way to tell if the req was ever inserted in a hash table, so better play safe.
>
Then I'm going to remove the /* temporary debugging */ line, so that
nobody will be tempted to drop the test.
Thanks for your feedbacks.
Guillaume
prev parent reply other threads:[~2019-03-09 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 21:09 [PATCH net] tcp: handle inet_csk_reqsk_queue_add() failures Guillaume Nault
2019-03-08 21:33 ` Eric Dumazet
2019-03-08 22:22 ` Guillaume Nault
2019-03-08 22:34 ` Eric Dumazet
2019-03-08 22:40 ` Guillaume Nault
2019-03-08 23:47 ` Eric Dumazet
2019-03-09 0:06 ` David Miller
2019-03-09 9:02 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309090234.GA29222@pc-2.home \
--to=gnault@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).