From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09C98C43381 for ; Sat, 9 Mar 2019 09:02:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD7D6207E0 for ; Sat, 9 Mar 2019 09:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726208AbfCIJCk (ORCPT ); Sat, 9 Mar 2019 04:02:40 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35002 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725681AbfCIJCk (ORCPT ); Sat, 9 Mar 2019 04:02:40 -0500 Received: by mail-wr1-f66.google.com with SMTP id t18so23788323wrx.2 for ; Sat, 09 Mar 2019 01:02:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OsUw5BOLZAomfPaAHBx/SLWRyM7uf29EhFIs08qVfCU=; b=UwkMHxJM/w3Jc10UImeQh2d47MXycfOkYXAvwRhO9yJnuyxSbYKWPyoPyXOQE8uclE 6WaFHGgWrlsj3uKao5jfB+WAzsY0WBX4pKvvSKyEgURmjKgNj2ZUBxcKl+ECcWkcsfNE 92m9TUnE5IuhRc4r8REI826fE4w55ucJQ22WRy0ONgvTIA6yCk2QfCynHp8RFaCyb33B 9LK0fPO2XWpzvoEPVUqC5TvBPfa7gXyo4Bft9xtqmuIUPIuwgmk1lcGTiEwWfuCSMKvS SoxQOjgy1d2Be7doXmi2vAFH3+0KZT97rxXdnOA1MoqLp6hOcBlEoEKULGwsdvhRiJRU Yo7A== X-Gm-Message-State: APjAAAUf+IJekGQt1JoKATrQvTX5kXMG8dEMdtnqymiRi9cBRhpm4fKQ rIP7l1qL72wXACQu8IPGQimRUA== X-Google-Smtp-Source: APXvYqxH0K8Ifw0CY8D3YUk9wUXoZUH/zUj72gVg+LJmNr5vWVmbi5g+Few9HOZVXAOcgYIgMWsDgQ== X-Received: by 2002:a05:6000:1287:: with SMTP id f7mr14543240wrx.203.1552122158474; Sat, 09 Mar 2019 01:02:38 -0800 (PST) Received: from pc-2.home (2a01cb05850ddf00045dd60e6368f84b.ipv6.abo.wanadoo.fr. [2a01:cb05:850d:df00:45d:d60e:6368:f84b]) by smtp.gmail.com with ESMTPSA id c10sm343583wrr.1.2019.03.09.01.02.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Mar 2019 01:02:38 -0800 (PST) Date: Sat, 9 Mar 2019 10:02:35 +0100 From: Guillaume Nault To: Eric Dumazet Cc: netdev@vger.kernel.org Subject: Re: [PATCH net] tcp: handle inet_csk_reqsk_queue_add() failures Message-ID: <20190309090234.GA29222@pc-2.home> References: <9b8502f9cec31c971e480ee2281f5cd7088b50df.1552077823.git.gnault@redhat.com> <20190308222231.GA26006@pc-2.home> <20190308224023.GA26735@pc-2.home> <69908e11-c7c7-b0aa-0382-618bae4e4572@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69908e11-c7c7-b0aa-0382-618bae4e4572@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 08, 2019 at 03:47:25PM -0800, Eric Dumazet wrote: > > On 03/08/2019 02:40 PM, Guillaume Nault wrote: > > On Fri, Mar 08, 2019 at 02:34:07PM -0800, Eric Dumazet wrote: > > > > Long term, do we want to keep the WARN_ON_ONCE()? If so, we should > > probably remove the comment. > > We want to keep the warning. > > We do not have a way to tell if the req was ever inserted in a hash table, so better play safe. > Then I'm going to remove the /* temporary debugging */ line, so that nobody will be tempted to drop the test. Thanks for your feedbacks. Guillaume