From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Song Liu <songliubraving@fb.com>
Cc: "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"acme@redhat.com" <acme@redhat.com>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"sdf@fomichev.me" <sdf@fomichev.me>
Subject: Re: [PATCH v8 perf,bpf 10/15] perf-top: add option --no-bpf-event
Date: Mon, 11 Mar 2019 18:17:09 -0300 [thread overview]
Message-ID: <20190311211709.GA4939@kernel.org> (raw)
In-Reply-To: <B1C5BA9A-20FB-46BA-A4D8-759CBA1C9ABD@fb.com>
Em Mon, Mar 11, 2019 at 09:07:20PM +0000, Song Liu escreveu:
>
>
> > On Mar 11, 2019, at 12:55 PM, Song Liu <songliubraving@fb.com> wrote:
> >
> > bpf events should be tracked by default for perf-top. This patch makes it
> > on by default, and adds option to disable bpf events.
> >
> > Signed-off-by: Song Liu <songliubraving@fb.com>
> > ---
> > tools/perf/builtin-top.c | 3 +++
> > tools/perf/util/top.h | 1 +
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> > index 27d8d42e0a4d..ccdf5689452f 100644
> > --- a/tools/perf/builtin-top.c
> > +++ b/tools/perf/builtin-top.c
> > @@ -1492,6 +1492,7 @@ int cmd_top(int argc, const char **argv)
> > "Display raw encoding of assembly instructions (default)"),
> > OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel,
> > "Enable kernel symbol demangling"),
> > + OPT_BOOLEAN(0, "no-bpf-event", &top.no_bpf_event, "do not record bpf events"),
> > OPT_STRING(0, "objdump", &top.annotation_opts.objdump_path, "path",
> > "objdump binary to use for disassembly and annotations"),
> > OPT_STRING('M', "disassembler-style", &top.annotation_opts.disassembler_style, "disassembler style",
> > @@ -1651,6 +1652,8 @@ int cmd_top(int argc, const char **argv)
> > signal(SIGWINCH, winch_sig);
> > }
> >
> > + top.record_opts.bpf_event = !top.no_bpf_event;
> > +
> > status = __cmd_top(&top);
> >
> > out_delete_evlist:
> > diff --git a/tools/perf/util/top.h b/tools/perf/util/top.h
> > index 19f95eaf75c8..862a37bd27ea 100644
> > --- a/tools/perf/util/top.h
> > +++ b/tools/perf/util/top.h
> > @@ -32,6 +32,7 @@ struct perf_top {
> > bool use_tui, use_stdio;
> > bool vmlinux_warned;
> > bool dump_symtab;
> > + bool no_bpf_event;
> > struct hist_entry *sym_filter_entry;
> > struct perf_evsel *sym_evsel;
> > struct perf_session *session;
> > --
> > 2.17.1
> >
>
> Hi Arnaldo,
>
> Currently, we have bpf-event default OFF for perf-record, with option to
> turn it ON; while bpf-event is default ON for perf-top, with option to
> turn if OFF. I think this is a little confusing.
>
> How about we set them both to default ON, and add option to turn it OFF?
Agreed.
> I think we still have time to make the change.
>
> Thanks,
> Song
>
>
--
- Arnaldo
next prev parent reply other threads:[~2019-03-11 21:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 19:55 [PATCH v8 perf,bpf 00/15] perf annotation of BPF programs Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 01/15] perf, bpf: consider events with attr.bpf_event as side-band events Song Liu
2019-03-11 20:29 ` Arnaldo Carvalho de Melo
2019-03-11 19:55 ` [PATCH v8 perf,bpf 02/15] bpf: libbpf: introduce bpf_program__get_prog_info_linear() Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 03/15] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 04/15] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 05/15] perf: change prototype of perf_event__synthesize_bpf_events() Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 10/15] perf-top: add option --no-bpf-event Song Liu
2019-03-11 21:07 ` Song Liu
2019-03-11 21:17 ` Arnaldo Carvalho de Melo [this message]
2019-03-11 19:55 ` [PATCH v8 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 12/15] perf, bpf: enable annotation of bpf program Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 13/15] perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 14/15] perf: introduce side band thread Song Liu
2019-03-11 19:55 ` [PATCH v8 perf,bpf 15/15] perf, bpf: save bpf_prog_info and btf of short living bpf programs Song Liu
2019-03-11 20:24 ` [PATCH v8 perf,bpf 00/15] perf annotation of BPF programs Arnaldo Carvalho de Melo
2019-03-11 21:01 ` Song Liu
2019-03-11 21:05 ` Arnaldo Carvalho de Melo
2019-03-11 21:08 ` Song Liu
2019-03-11 21:18 ` Arnaldo Carvalho de Melo
2019-03-11 21:22 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311211709.GA4939@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=Kernel-team@fb.com \
--cc=acme@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sdf@fomichev.me \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).