From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2531C43381 for ; Tue, 12 Mar 2019 03:52:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D5D7214AF for ; Tue, 12 Mar 2019 03:52:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727146AbfCLDwu (ORCPT ); Mon, 11 Mar 2019 23:52:50 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:36932 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727100AbfCLDwp (ORCPT ); Mon, 11 Mar 2019 23:52:45 -0400 Received: by mail-qk1-f193.google.com with SMTP id c1so654871qkk.4 for ; Mon, 11 Mar 2019 20:52:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=E/UyB+xWk/xehLCQmoblfGNsmlWELdfSb6B+opPtGT0=; b=HP7hoJFytyasZEOaPILNluIPoZb2w3SNXxJnHUUCugvbE8Br/kLYcvj/Ie61/IczxT nwWhvLXIps2gKasq/IEXyLJDJAn5kho+q/c4Sgo3viW2OeasvOZkR+BHL67/qzHX1NAA Z40P7V4fTA8C5dwa/gzg1ocX0nvHA0aM+w3VqsJzW/98dNyFn7bEAa0oBU9S0VVYSVYE EJNKvVSReQ5KqmVgBWeTjQUybk60HNMLuuXiy4a0e+4KlHNpNalDxyi0uE3jALdjpEMX fCSFGjIvOMl1ydYxy/JJ+h7C0MNlsYIRVOmiKI3zOTARTc0xpOCDzlopQv9hs6Kq/xSa 08zA== X-Gm-Message-State: APjAAAUEy2aIR0ga7eKHZyfKFx4ZNN/ZgkqMoaVf9/7gDqK2+fZlK9yx sHiIwa1Ug8TrBgDoWh+LgcJc7w== X-Google-Smtp-Source: APXvYqw6vWNjN7roQr24NYlwA5iXQwWdK6cI38JZZ7g3cWXw6ntcj/yHKj2a9lBFrAD0H1GF5Tax7A== X-Received: by 2002:ae9:c30f:: with SMTP id n15mr4412813qkg.227.1552362764721; Mon, 11 Mar 2019 20:52:44 -0700 (PDT) Received: from redhat.com (pool-173-76-246-42.bstnma.fios.verizon.net. [173.76.246.42]) by smtp.gmail.com with ESMTPSA id o188sm4099469qkd.30.2019.03.11.20.52.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Mar 2019 20:52:43 -0700 (PDT) Date: Mon, 11 Mar 2019 23:52:41 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: David Miller , hch@infradead.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, peterx@redhat.com, linux-mm@kvack.org, aarcange@redhat.com, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org Subject: Re: [RFC PATCH V2 0/5] vhost: accelerate metadata access through vmap() Message-ID: <20190311235140-mutt-send-email-mst@kernel.org> References: <20190308141220.GA21082@infradead.org> <56374231-7ba7-0227-8d6d-4d968d71b4d6@redhat.com> <20190311095405-mutt-send-email-mst@kernel.org> <20190311.111413.1140896328197448401.davem@davemloft.net> <6b6dcc4a-2f08-ba67-0423-35787f3b966c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6b6dcc4a-2f08-ba67-0423-35787f3b966c@redhat.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 12, 2019 at 10:59:09AM +0800, Jason Wang wrote: > > On 2019/3/12 上午2:14, David Miller wrote: > > From: "Michael S. Tsirkin" > > Date: Mon, 11 Mar 2019 09:59:28 -0400 > > > > > On Mon, Mar 11, 2019 at 03:13:17PM +0800, Jason Wang wrote: > > > > On 2019/3/8 下午10:12, Christoph Hellwig wrote: > > > > > On Wed, Mar 06, 2019 at 02:18:07AM -0500, Jason Wang wrote: > > > > > > This series tries to access virtqueue metadata through kernel virtual > > > > > > address instead of copy_user() friends since they had too much > > > > > > overheads like checks, spec barriers or even hardware feature > > > > > > toggling. This is done through setup kernel address through vmap() and > > > > > > resigter MMU notifier for invalidation. > > > > > > > > > > > > Test shows about 24% improvement on TX PPS. TCP_STREAM doesn't see > > > > > > obvious improvement. > > > > > How is this going to work for CPUs with virtually tagged caches? > > > > > > > > Anything different that you worry? > > > If caches have virtual tags then kernel and userspace view of memory > > > might not be automatically in sync if they access memory > > > through different virtual addresses. You need to do things like > > > flush_cache_page, probably multiple times. > > "flush_dcache_page()" > > > I get this. Then I think the current set_bit_to_user() is suspicious, we > probably miss a flush_dcache_page() there: > > > static int set_bit_to_user(int nr, void __user *addr) > { >         unsigned long log = (unsigned long)addr; >         struct page *page; >         void *base; >         int bit = nr + (log % PAGE_SIZE) * 8; >         int r; > >         r = get_user_pages_fast(log, 1, 1, &page); >         if (r < 0) >                 return r; >         BUG_ON(r != 1); >         base = kmap_atomic(page); >         set_bit(bit, base); >         kunmap_atomic(base); >         set_page_dirty_lock(page); >         put_page(page); >         return 0; > } > > Thanks I think you are right. The correct fix though is to re-implement it using asm and handling pagefault, not gup. Three atomic ops per bit is way to expensive. -- MST