From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF86C43381 for ; Tue, 12 Mar 2019 21:54:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AADC92077B for ; Tue, 12 Mar 2019 21:54:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726680AbfCLVyp (ORCPT ); Tue, 12 Mar 2019 17:54:45 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54746 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbfCLVyp (ORCPT ); Tue, 12 Mar 2019 17:54:45 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DC98114CD1310; Tue, 12 Mar 2019 14:54:43 -0700 (PDT) Date: Tue, 12 Mar 2019 14:54:43 -0700 (PDT) Message-Id: <20190312.145443.966175629804121821.davem@davemloft.net> To: kjlu@umn.edu Cc: pakki001@umn.edu, peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, maxime.ripard@bootlin.com, wens@csie.org, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dwmac-sun8i: fix a missing check of of_get_phy_mode From: David Miller In-Reply-To: <20190312075040.32115-1-kjlu@umn.edu> References: <20190312075040.32115-1-kjlu@umn.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Mar 2019 14:54:44 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Kangjie Lu Date: Tue, 12 Mar 2019 02:50:40 -0500 > of_get_phy_mode may fail and return a negative error code; > the fix checks the return value of of_get_phy_mode and > returns -EINVAL of it fails. > > Signed-off-by: Kangjie Lu Applied.