From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6CDFC4360F for ; Tue, 12 Mar 2019 07:51:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C2FE214D8 for ; Tue, 12 Mar 2019 07:51:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="nHSku0XL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727473AbfCLHuv (ORCPT ); Tue, 12 Mar 2019 03:50:51 -0400 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:55004 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbfCLHuv (ORCPT ); Tue, 12 Mar 2019 03:50:51 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 94329A98 for ; Tue, 12 Mar 2019 07:50:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GdYLq1gEklBY for ; Tue, 12 Mar 2019 02:50:49 -0500 (CDT) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 6110B9B8 for ; Tue, 12 Mar 2019 02:50:49 -0500 (CDT) Received: by mail-io1-f72.google.com with SMTP id d7so1166488ios.17 for ; Tue, 12 Mar 2019 00:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=cCzogPH+NILYsqX4kJaeZubessnMrupncJNs9YIpvCw=; b=nHSku0XLPT8YAk3cPSEu5ouAgNXBY137dQqHd7glQY1duamQeYYEYMMF8EbxnAQiW4 BSgPlerCbgnEeLV2mivsCmK+ZAo9x/hsQv/WJEiq2iIG7ogyy3UhBJZd82rwafWRqlp9 7itDVVnNCWCtUxYY6Wpv0NkqTOpIC8u0NrIUiucmlT+bov+QrXc+1lI03+7IIomUWBIu b6ldMUpfSXaQogsfwYKZ93I1cTZ/wAiiF5LN4ngWcUj8auo5mh/Nb/hcMlacCAK320/e kgjwCcTEmvruFRJmxksIWoA9t/szI88I+8M7Up6bM6KwfyMAGyR9GCX8pJRS5f1rXsLs VSPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cCzogPH+NILYsqX4kJaeZubessnMrupncJNs9YIpvCw=; b=HMhqFmHd1Z2wjxPhIYKXMeT3fSXSE6S34ZiLWxVzSSomBZMoaxxcU/PIXfGARE6tBe 2NVuwvGysdnOkT11zbatdZFDNy4C7jgPSk4ht+NL0KkdAmSsmnDSU16e/cpAKTFpC+aE sv6EOsou5GpIkFGMSl6AOLDHsdn5gYEewTM3zHsY/2rIrWPqjRxni4HxbGII0CSZSJ0U vJ+ewD9WlT83kmY5fBLs6fJL0Ktl1DkIPMbKFTplkkAlkVkn68qrACn/L2sDvAORzQ2R ttmuflvH2lKbyUidaXvC0Xp6bxIqOHDBJ2oAaDgPBsqsS6/Y9zpa3JgoES8ldDITrMEq WkTQ== X-Gm-Message-State: APjAAAWI5zOXz3wx4ri8gj0/oOY3B5Qqh5g++aDeNk+W0KCS63oO7alL p+M+6FhXec2fGAvRa7CTuUDMyzxmuwvaEf/1lUI1CmMjxe3hAKpxTZegE2RHH6QjPh00cTgGwn3 fJ+AMmyV0yKcEToQH+FkN X-Received: by 2002:a5d:93d9:: with SMTP id j25mr20449493ioo.305.1552377049005; Tue, 12 Mar 2019 00:50:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqySKdTwSbF12uEqKV+X5R0H6vQ6AW+F8lgxZfBZnn/CNF8EZx5T4x9srmlhOqht6eSmWxveLA== X-Received: by 2002:a5d:93d9:: with SMTP id j25mr20449475ioo.305.1552377048729; Tue, 12 Mar 2019 00:50:48 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id c14sm3409784iot.13.2019.03.12.00.50.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 00:50:48 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Ripard , Chen-Yu Tsai , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org Subject: [PATCH] net: dwmac-sun8i: fix a missing check of of_get_phy_mode Date: Tue, 12 Mar 2019 02:50:40 -0500 Message-Id: <20190312075040.32115-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org of_get_phy_mode may fail and return a negative error code; the fix checks the return value of of_get_phy_mode and returns -EINVAL of it fails. Signed-off-by: Kangjie Lu --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 0f660af01a4b..195669f550f0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -1147,7 +1147,10 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) return ret; } - plat_dat->interface = of_get_phy_mode(dev->of_node); + ret = of_get_phy_mode(dev->of_node); + if (ret < 0) + return -EINVAL; + plat_dat->interface = ret; /* platform data specifying hardware features and callbacks. * hardware features were copied from Allwinner drivers. -- 2.17.1