From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=6NTP=RP=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT
	autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 773DCC43381
	for <netdev@archiver.kernel.org>; Tue, 12 Mar 2019 08:07:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 4FD7F214AE
	for <netdev@archiver.kernel.org>; Tue, 12 Mar 2019 08:07:14 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727526AbfCLIHK (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 12 Mar 2019 04:07:10 -0400
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:48827 "EHLO
        relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726714AbfCLIHK (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 12 Mar 2019 04:07:10 -0400
X-Originating-IP: 90.88.150.179
Received: from localhost (aaubervilliers-681-1-31-179.w90-88.abo.wanadoo.fr [90.88.150.179])
        (Authenticated sender: maxime.ripard@bootlin.com)
        by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 106441BF204;
        Tue, 12 Mar 2019 08:07:04 +0000 (UTC)
Date:   Tue, 12 Mar 2019 09:07:04 +0100
From:   Maxime Ripard <maxime.ripard@bootlin.com>
To:     Kangjie Lu <kjlu@umn.edu>
Cc:     pakki001@umn.edu, Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Chen-Yu Tsai <wens@csie.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dwmac-sun8i: fix a missing check of of_get_phy_mode
Message-ID: <20190312080704.jjzv62qsrtcje7gd@flea>
References: <20190312075040.32115-1-kjlu@umn.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="mqil5gvgnush4ee5"
Content-Disposition: inline
In-Reply-To: <20190312075040.32115-1-kjlu@umn.edu>
User-Agent: NeoMutt/20180716
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org


--mqil5gvgnush4ee5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 12, 2019 at 02:50:40AM -0500, Kangjie Lu wrote:
> of_get_phy_mode may fail and return a negative error code;
> the fix checks the return value of of_get_phy_mode and
> returns -EINVAL of it fails.
>=20
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>

Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Thanks!
Maxime

--=20
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--mqil5gvgnush4ee5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXIdoqAAKCRDj7w1vZxhR
xcMUAPsGMGKv+6UsUy6tuiVORbIt7imnYRlNhwI6m9mlLPLZfgEA6zrDadYI0wyC
4KgOSMsMnF5zZKMm0854otRXGbEEogQ=
=LZgo
-----END PGP SIGNATURE-----

--mqil5gvgnush4ee5--