From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB642C43381 for ; Tue, 12 Mar 2019 23:19:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 351A82147C for ; Tue, 12 Mar 2019 23:19:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="1+ht9BUo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727245AbfCLXTh (ORCPT ); Tue, 12 Mar 2019 19:19:37 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:48944 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727148AbfCLXTh (ORCPT ); Tue, 12 Mar 2019 19:19:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HGNsCB6oaks0KI881aQCqX4hSwE7o/W3QfxugPtW6jA=; b=1+ht9BUoJz5YqD3Bo+rZanki+ 5560wO1VcOFoMn0iSPpIVZSqvEqZuhwnt3C4Gf98q+qoZyJfET5Kw8R2BJpPG1lzbLDYWEUl/kxfw kOqS9jhSBy8lgmJHgYxVVIQIGaSnNKTwPYzA9yDsihePErvtRfp2POlGEWbAAP3ChBpYdmItMxBjn p9MySyPi8M85eSFhNUQPvta1qOgMTr5OJouxfPc5g+dh23qA7LL97jKUvW1cK03/o2OLQsW7r7vPp 1hUQ9A3Tg+72nt28gRavG8OflMJiRdfChgR6bkzg6HER12QIEVL4AYGDy9cY0aBDMxjb6+zuAmfKZ lB+rj219Q==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:55078) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1h3qgC-0006NO-KJ; Tue, 12 Mar 2019 23:19:28 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1h3qg2-00012U-Ij; Tue, 12 Mar 2019 23:19:18 +0000 Date: Tue, 12 Mar 2019 23:19:18 +0000 From: Russell King - ARM Linux admin To: Daniel Mack Cc: Heiko Stuebner , Andrew Lunn , david.wu@rock-chips.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, David Miller , linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com Subject: Re: [PATCH net-next] net: phy: improve handling link_change_notify callback Message-ID: <20190312231918.csaemkfjx53yxlrh@shell.armlinux.org.uk> References: <411b1c33-a245-0706-8afd-c4bea1b90f68@gmail.com> <20190304.113025.1437399524067140375.davem@davemloft.net> <20190304200630.GJ26378@lunn.ch> <3079158.ITs3Wk0qno@phil> <945fb25c-c854-27f3-1e98-18a5c981d59f@zonque.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <945fb25c-c854-27f3-1e98-18a5c981d59f@zonque.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 12, 2019 at 06:50:59PM +0100, Daniel Mack wrote: > On 12/3/2019 1:27 PM, Heiko Stuebner wrote: > > Hi Andrew, Heiner, > > > > Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn: > >> On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: > >>> From: Heiner Kallweit > >>> Date: Sun, 3 Mar 2019 19:58:57 +0100 > >>> > >>>> Currently the Phy driver's link_change_notify callback is called > >>>> whenever the state machine is run (every second if polling), no matter > >>>> whether the state changed or not. This isn't needed and may confuse > >>>> users considering the name of the callback. Therefore let's change > >>>> the behavior and call this callback only in case of an actual > >>>> state change. > >>>> > >>>> This requires changes to the at803x and rockchip drivers. > >>>> at803x can be simplified so that it reacts on a state change to > >>>> PHY_NOLINK only. > >>>> The rockchip driver can also be much simplified. We simply re-init > >>>> the AFE/DSP registers whenever we change to PHY_RUNNING and speed > >>>> is 100Mbps. This causes very small overhead because we do this even > >>>> if the speed was 100Mbps already. But this is neglectable and > >>>> I think justified by the much simpler code. > >>>> > >>>> Changes are compile-tested only. > >>>> > >>>> Signed-off-by: Heiner Kallweit > >>> > >>> Someone please review this. > >> > >> Hi David > >> > >> We should probably wait for a Tested-by: from Daniel Mack > >> and David Wu , or > >> equivalent. > > > > We should probably add them to the list of recipients if we want > > tests from them, which I've done now. > > > > @David: patch in question that changes the Rockchip eth-phy is > > https://patchwork.kernel.org/patch/10837217/ > > > > Sadly I don't have matching hardware to test this myself. > > Thanks for considering me, but I don't have access to that hardware > either right now. > > The changes look straight forward to me however, so just go ahead an > apply this. Once I get back to that setup, I'll report in case of a > regression. SolidRun Hummingboards and Cubox-i use AR8035 with the FEC driver, so would be ideal to test - unfortunately I'm up to my eyeballs trying to diagnose Armada 8040 comphy issues so can't test at the moment. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up