From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF95C43381 for ; Wed, 13 Mar 2019 11:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F91E2183F for ; Wed, 13 Mar 2019 11:21:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725883AbfCMLVp (ORCPT ); Wed, 13 Mar 2019 07:21:45 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:38572 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725856AbfCMLVp (ORCPT ); Wed, 13 Mar 2019 07:21:45 -0400 Received: from cpe-2606-a000-111b-405a-9816-2c85-c514-8f7a.dyn6.twc.com ([2606:a000:111b:405a:9816:2c85:c514:8f7a] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1h41ww-0006AH-G7; Wed, 13 Mar 2019 07:21:36 -0400 Date: Wed, 13 Mar 2019 07:21:02 -0400 From: Neil Horman To: David Miller Cc: netdev@vger.kernel.org, marcelo.leitner@gmail.com, lucien.xin@gmail.com Subject: Re: [PATCH RFC v4 0/5] SCTP: Event skb list overhaul. Message-ID: <20190313112102.GA16434@hmswarspite.think-freely.org> References: <20190311.200919.2201899718784012074.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190311.200919.2201899718784012074.davem@davemloft.net> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 11, 2019 at 08:09:19PM -0700, David Miller wrote: > > This patch series eliminates the explicit reference to the skb list > implementation via skb->prev dereferences. > > The approach used is to pass a non-empty skb list around instead of an > event skb object which may or may not be on a list. > > I'd like to thank Marcelo Leitner, Xin Long, and Neil Horman for > reviewing previous versions of this series. > > Testing would be very much appreciated, in addition to the review of > course. > > v3 --> v4: Fix the logic in patch #4 so that we don't miss cases > where we should add event to the on-stack temp list. > > Signed-off-by: David S. Miller > I think this looks good now, thanks for taking the time on it Dave Acked-by: Neil Horman