From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7383EC43381 for ; Wed, 13 Mar 2019 16:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 407372146E for ; Wed, 13 Mar 2019 16:06:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PMQ2Wl3J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726627AbfCMQG0 (ORCPT ); Wed, 13 Mar 2019 12:06:26 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:40373 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfCMQG0 (ORCPT ); Wed, 13 Mar 2019 12:06:26 -0400 Received: by mail-qk1-f195.google.com with SMTP id h28so1408203qkk.7 for ; Wed, 13 Mar 2019 09:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tDPswy9zYS9jacHJhGm1+jLns9mCQOBlLs6HrhrkQoE=; b=PMQ2Wl3J6aB7tRDaXHCYq4CSlX422w841F5WgDF44bMQYIf0kqxGyhVTQHWqPcaPw4 yjSjy4qk+ESKO5v+ozfbAdrhSjPflJLaFCgIjdg8OPbD5t1bDZVi7EL7mMyb78+ztnYs 7p4vmfp5iV9PG+V7CrAtOrPY9PZBG7NhUIU8xCqfc0ZuELDeHigtjo3+Cw7C8RHt5TG+ WHhsSrsaowmYcsSpMJ7bxSQtCI1RGLOhX8IUj0J+UqWdLsEYYqFjSowgukYdLHMW17l6 DtgslgoL4GPKIZWGkRt+q/TM91e6qQ+TlT9hMNiOcW0ei0wGTETbnLaAdVfXj2+dypWh VpCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tDPswy9zYS9jacHJhGm1+jLns9mCQOBlLs6HrhrkQoE=; b=RVIPBYJN9D0FN9Omc9GKD2O50KOoglIL2jrFzR8vIWkEmPZ1NUH3R8TDMY6bTCI5H3 j4PLtjAtt3ZqspvUXEf7MqvJoEhGuwNssHauWKsrWYWfWinmet/ZK7MwWhH6ONqeovCn rtRrIn+tT6/Pp38vzSyp/zPEuMclNByHaMy3stslxeh0A4I1fKtWiXh25Y1VFBxaiJLM 7MUdwUYhq/SDWdrNHrCQdghaeJVrwRiypDJw8pSKRC7jbQ51zQG6jAcg9ql04iNN8+po VwOLfiQu4bgkH7z/p+HIrZSTrx/q1ZbiQ93v+wY67Dmf2EE5IqltEf8O3rtE4TKh56yr 6gfA== X-Gm-Message-State: APjAAAXLhonxPftglQy/AWPHOqM0EOfkNeLlxoGy6sYg+/hx1o9hTRf+ 7AF2zoC+iUoy153qg0w252w= X-Google-Smtp-Source: APXvYqxIEWSqvFs28PY1zI1Z2nQjg1g2iPFzkBAVRL8Dg8j2r2y4baDFKkv8UnZB6vfO1jhIYAljlg== X-Received: by 2002:ae9:e007:: with SMTP id m7mr4076193qkk.248.1552493184830; Wed, 13 Mar 2019 09:06:24 -0700 (PDT) Received: from localhost.localdomain ([177.220.172.154]) by smtp.gmail.com with ESMTPSA id g7sm5799543qkd.12.2019.03.13.09.06.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Mar 2019 09:06:24 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 57D85180C43; Wed, 13 Mar 2019 13:06:21 -0300 (-03) Date: Wed, 13 Mar 2019 13:06:21 -0300 From: Marcelo Ricardo Leitner To: David Miller Cc: netdev@vger.kernel.org, lucien.xin@gmail.com, nhorman@tuxdriver.com Subject: Re: [PATCH RFC v4 0/5] SCTP: Event skb list overhaul. Message-ID: <20190313160621.GI13343@localhost.localdomain> References: <20190311.200919.2201899718784012074.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190311.200919.2201899718784012074.davem@davemloft.net> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 11, 2019 at 08:09:19PM -0700, David Miller wrote: > > This patch series eliminates the explicit reference to the skb list > implementation via skb->prev dereferences. > > The approach used is to pass a non-empty skb list around instead of an > event skb object which may or may not be on a list. > > I'd like to thank Marcelo Leitner, Xin Long, and Neil Horman for > reviewing previous versions of this series. > > Testing would be very much appreciated, in addition to the review of > course. > > v3 --> v4: Fix the logic in patch #4 so that we don't miss cases > where we should add event to the on-stack temp list. > > Signed-off-by: David S. Miller Code review LGTM too. Running some tests, should be done by the end of the day. Marcelo