From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916B8C43381 for ; Wed, 13 Mar 2019 16:35:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5609F2146E for ; Wed, 13 Mar 2019 16:35:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="xpDSmLeO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726513AbfCMQfG (ORCPT ); Wed, 13 Mar 2019 12:35:06 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:36845 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbfCMQfF (ORCPT ); Wed, 13 Mar 2019 12:35:05 -0400 Received: by mail-wr1-f66.google.com with SMTP id g18so2738384wru.3 for ; Wed, 13 Mar 2019 09:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=r0Yh7k3RKBijgWJbQZkTI9F0bO5jplQk0B5wOScpKFA=; b=xpDSmLeOBJQ86UxvUKa3Lf9GMtNU3sJTP1MFFpZZbUEyJwlmzVnxC460+qxFIiYUIK WQr7yCK/pdvXI7K+A+/L8GBbJtUn0YqfP0/lOjmQP2jh2tKN2onV6NplXk4J7fBh+kkA U9hTkPQ/rqmsLkwBzBrmxzqrTGJpyICD4wE0871PQmZJFCa/aXDTci/aQXxtayahHr0V cxRcQKpfdCTWPG0QMDOU2xve13gDq8Z+eqFX0NGcfXdcNLOzxxXIxnr0be6rpmHyaTDe M+ZStqUtPfZBak2S3cgHTLPD1sORXa7/KLfkvOtvYBA7SriLSfEZYlXzuHApSFsHRudv eLFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=r0Yh7k3RKBijgWJbQZkTI9F0bO5jplQk0B5wOScpKFA=; b=tZFLL5fCeP3sUaxWRVZDiFCmt7lCBOBumyXHbZiddxElTSP49z0372FIkhrLX5gQ2c rjgUHR4I2oz78QvxFjWVOykG+OeEOBBblHpBftXysFGYTQ9ABoRhCahtjOzox/zqv/yy Jm8nGBmElrCwU4UvaIRtOX+az3l4l39ASRItOYZg+blasYr6jxeamI/CQm42b9q8iz1m cPT7R0srgaQ2lfgXHvsdw12M4twvxjmQBCuaz7yOTGf2rthLmYB8jmIpckNMxMttOM/v IVUwffwCLPQvWpuGu7stW5THMKYWL3k6y7CVORyrFR421MrCWiG0O/kOuMi958ziCfsw nybQ== X-Gm-Message-State: APjAAAXMF9Zl8xB2vyO2fqXjvCzjnbwEU5IBf6mj+qbHHbm8S9K9adOG W/RqfeITXB8lYNKLLx9OhAb7MQ== X-Google-Smtp-Source: APXvYqxzzOa1L3HIFDbiKaKLxmO2zXHKN4A2VX8DEDxWd0A29wjAkcG6CnSBf3xSbZ+CRP8lhEa3NQ== X-Received: by 2002:a5d:6843:: with SMTP id o3mr28037008wrw.165.1552494904143; Wed, 13 Mar 2019 09:35:04 -0700 (PDT) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id j4sm2567805wrw.68.2019.03.13.09.35.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Mar 2019 09:35:03 -0700 (PDT) Date: Wed, 13 Mar 2019 17:24:40 +0100 From: Jiri Pirko To: "Samudrala, Sridhar" Cc: Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190313162440.GC2270@nanopsycho> References: <20190307094816.GA2190@nanopsycho> <20190307185202.2db37490@cakuba.hsd1.ca.comcast.net> <20190308145421.GA2888@nanopsycho.orion> <20190308110943.2ee42bc0@cakuba.hsd1.ca.comcast.net> <20190311085204.GA2194@nanopsycho> <20190311191054.36b801d6@cakuba.hsd1.ca.comcast.net> <20190312140239.GA2455@nanopsycho> <7227d58e-ac58-d549-b921-ca0a0dd3f4b0@intel.com> <20190313073702.GA2270@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Mar 13, 2019 at 05:03:17PM CET, sridhar.samudrala@intel.com wrote: >On 3/13/2019 12:37 AM, Jiri Pirko wrote: >> Wed, Mar 13, 2019 at 07:17:04AM CET, sridhar.samudrala@intel.com wrote: >> > >> > On 3/12/2019 7:02 AM, Jiri Pirko wrote: >> > >> > > >> > > > >> > > > > I originally planned to implement sriov orchestration api in devlink too. >> > > > >> > > > Interesting, would you mind elaborating? >> > > >> > > I have to think about it. But something like this: >> > > >> > > After bootup, you see only physical port, PF switch port and PF host leg. >> > >> > Is this after changing the eswitch mode to 'switchdev' >> >> I believe so. For new drivers, this should be default and only option. >> >> >> > >> > > $ devlink port show >> > > pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical switch_id 00154d130d2 >> > >> > Is this the uplink port representor? >> >> Yes >> >> >> > >> > > pci/0000:05:00.0/1: type eth netdev ??? flavour pci_pf_host >> > > peer pci/0000:05:00.0/10000 >> > >> > I guess this is PF netdev >> >> Yes, port >> >> >> > >> > > pci/0000:05:00.0/10000: type eth netdev enp5s0npf0pf0s0 flavour pci_pf pf 0 subport 0 >> > > switch_id 00154d130d2f peer pci/0000:05:00.0/1 >> > >> > and this one is PF port representor netdev >> >> Yes, port >> >> >> > >> > > >> > > To create new PF subport under PF 0: >> > > $ devlink dev port add pci/0000:05:00.0 flavour pci_pf pf 0 >> > >> > Can we consider l2-fwd offload macvlan device also as a subport of PF? >> >> What does this have to with with macvlan? Macvlan is a separate soft >> driver. > >ethtool -k l2-fwd-offload on >ip link add link type macvlan > >will create a macvlan netdev but it is backed by a set of separate HW queues >and switching is offloaded to HW. This can be considered as a subport. In >i40e, it is a VMDq VSI. Oh, this one. I think that is abuse of macvlan. We should do the modelling correctly, including visibility of switch ports. > > > >