netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND ethtool] ethtool: add 10000baseR_FEC link mode name
@ 2019-02-27 13:49 Michal Kubecek
  2019-03-14 18:37 ` John W. Linville
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Kubecek @ 2019-02-27 13:49 UTC (permalink / raw)
  To: John W. Linville; +Cc: netdev

ETHTOOL_LINK_MODE_10000baseR_FEC_BIT link mode is listed in
ethtool_link_mode_bit_indices array but doesn't have its name assigned in
the table in dump_link_caps() (so that it's not shown in "ethtool <dev>"
output) and is not listed in the manual page. Add it to both.

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
---
 ethtool.8.in | 1 +
 ethtool.c    | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/ethtool.8.in b/ethtool.8.in
index 5a26cff5fb33..3d288eaadf23 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -633,6 +633,7 @@ lB	l	lB.
 0x1000	10000baseT Full
 0x40000	10000baseKX4 Full
 0x80000	10000baseKR Full
+0x100000	10000baseR_FEC
 0x40000000000	10000baseCR  Full
 0x80000000000	10000baseSR  Full
 0x100000000000	10000baseLR  Full
diff --git a/ethtool.c b/ethtool.c
index fb4c0886ca84..b6a1eaa383a3 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -633,6 +633,8 @@ static void dump_link_caps(const char *prefix, const char *an_prefix,
 		  "10000baseKX4/Full" },
 		{ 0, ETHTOOL_LINK_MODE_10000baseKR_Full_BIT,
 		  "10000baseKR/Full" },
+		{ 0, ETHTOOL_LINK_MODE_10000baseR_FEC_BIT,
+		  "10000baseR_FEC" },
 		{ 0, ETHTOOL_LINK_MODE_20000baseMLD2_Full_BIT,
 		  "20000baseMLD2/Full" },
 		{ 0, ETHTOOL_LINK_MODE_20000baseKR2_Full_BIT,
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND ethtool] ethtool: add 10000baseR_FEC link mode name
  2019-02-27 13:49 [PATCH RESEND ethtool] ethtool: add 10000baseR_FEC link mode name Michal Kubecek
@ 2019-03-14 18:37 ` John W. Linville
  0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2019-03-14 18:37 UTC (permalink / raw)
  To: Michal Kubecek; +Cc: netdev

On Wed, Feb 27, 2019 at 02:49:04PM +0100, Michal Kubecek wrote:
> ETHTOOL_LINK_MODE_10000baseR_FEC_BIT link mode is listed in
> ethtool_link_mode_bit_indices array but doesn't have its name assigned in
> the table in dump_link_caps() (so that it's not shown in "ethtool <dev>"
> output) and is not listed in the manual page. Add it to both.
> 
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>

Queued for next release -- thanks!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-14 18:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-27 13:49 [PATCH RESEND ethtool] ethtool: add 10000baseR_FEC link mode name Michal Kubecek
2019-03-14 18:37 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).