* [PATCH] qlcnic: Avoid potential NULL pointer dereference
@ 2019-03-14 20:26 Aditya Pakki
0 siblings, 0 replies; 3+ messages in thread
From: Aditya Pakki @ 2019-03-14 20:26 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Shahed Shaikh, Manish Chopra, GR-Linux-NIC-Dev,
David S. Miller, netdev, linux-kernel
netdev_alloc_skb can fail and return a NULL pointer which is
dereferenced without a check. The patch avoids such a scenario.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
index 3b0adda7cc9c..826571029b21 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
@@ -1048,6 +1048,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode)
for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) {
skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE);
+ if (!unlikely(skb))
+ break;
qlcnic_create_loopback_buff(skb->data, adapter->mac_addr);
skb_put(skb, QLCNIC_ILB_PKT_SIZE);
adapter->ahw->diag_cnt = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] qlcnic: Avoid potential NULL pointer dereference
@ 2019-03-14 20:31 Aditya Pakki
2019-03-15 18:56 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Aditya Pakki @ 2019-03-14 20:31 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Shahed Shaikh, Manish Chopra, GR-Linux-NIC-Dev,
David S. Miller, netdev, linux-kernel
netdev_alloc_skb can fail and return a NULL pointer which is
dereferenced without a check. The patch avoids such a scenario.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
index 3b0adda7cc9c..a4cd6f2cfb86 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
@@ -1048,6 +1048,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode)
for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) {
skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE);
+ if (!skb)
+ break;
qlcnic_create_loopback_buff(skb->data, adapter->mac_addr);
skb_put(skb, QLCNIC_ILB_PKT_SIZE);
adapter->ahw->diag_cnt = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qlcnic: Avoid potential NULL pointer dereference
2019-03-14 20:31 Aditya Pakki
@ 2019-03-15 18:56 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2019-03-15 18:56 UTC (permalink / raw)
To: pakki001; +Cc: kjlu, shshaikh, manishc, GR-Linux-NIC-Dev, netdev, linux-kernel
From: Aditya Pakki <pakki001@umn.edu>
Date: Thu, 14 Mar 2019 15:31:40 -0500
> netdev_alloc_skb can fail and return a NULL pointer which is
> dereferenced without a check. The patch avoids such a scenario.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-15 18:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-14 20:26 [PATCH] qlcnic: Avoid potential NULL pointer dereference Aditya Pakki
-- strict thread matches above, loose matches on Subject: below --
2019-03-14 20:31 Aditya Pakki
2019-03-15 18:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).