From: David Miller <davem@davemloft.net>
To: aaro.koskinen@iki.fi
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, thor.thayer@linux.intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
aaro.koskinen@nokia.com
Subject: Re: [PATCH 1/2] net: stmmac: don't set own bit too early for jumbo frames
Date: Fri, 15 Mar 2019 11:39:18 -0700 (PDT) [thread overview]
Message-ID: <20190315.113918.418776680846022851.davem@davemloft.net> (raw)
In-Reply-To: <20190314194320.25566-1-aaro.koskinen@iki.fi>
From: Aaro Koskinen <aaro.koskinen@iki.fi>
Date: Thu, 14 Mar 2019 21:43:19 +0200
> From: Aaro Koskinen <aaro.koskinen@nokia.com>
>
> Commit 0e80bdc9a72d ("stmmac: first frame prep at the end of xmit
> routine") overlooked jumbo frames when re-ordering the code, and as a
> result the own bit was not getting set anymore for the first jumbo frame
> descriptor. Commit 487e2e22ab79 ("net: stmmac: Set OWN bit for jumbo
> frames") tried to fix this, but now the bit is getting set too early and
> the DMA may start while we are still setting up the remaing descriptors.
> And with the chain mode the own bit remains still unset.
>
> Fix by setting the own bit at the end of xmit also with jumbo frames.
>
> Fixes: 0e80bdc9a72d ("stmmac: first frame prep at the end of xmit routine")
> Fixes: 487e2e22ab79 ("net: stmmac: Set OWN bit for jumbo frames")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Applied with the "remaining" typo fixed.
prev parent reply other threads:[~2019-03-15 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 19:43 [PATCH 1/2] net: stmmac: don't set own bit too early for jumbo frames Aaro Koskinen
2019-03-14 19:43 ` [PATCH 2/2] net: stmmac: fix jumbo frame sending with non-linear skbs Aaro Koskinen
2019-03-15 9:50 ` Jose Abreu
2019-03-15 18:39 ` David Miller
2019-03-15 8:45 ` [PATCH 1/2] net: stmmac: don't set own bit too early for jumbo frames Sergei Shtylyov
2019-03-15 9:47 ` Jose Abreu
2019-03-15 18:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315.113918.418776680846022851.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aaro.koskinen@iki.fi \
--cc=aaro.koskinen@nokia.com \
--cc=alexandre.torgue@st.com \
--cc=joabreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).