* [PATCH] net: sis900: fix indentation issues, remove some spaces
@ 2019-03-14 23:56 Colin King
2019-03-15 18:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-03-14 23:56 UTC (permalink / raw)
To: Daniele Venzano, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are several statements that contain extra spacing in
the indentation; clean this up by removing spaces. Also
add { } braces on if statement to keep to kernel coding
style.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/sis/sis900.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
index 6073387511f8..67f9bb6e941b 100644
--- a/drivers/net/ethernet/sis/sis900.c
+++ b/drivers/net/ethernet/sis/sis900.c
@@ -730,10 +730,10 @@ static u16 sis900_default_phy(struct net_device * net_dev)
status = mdio_read(net_dev, phy->phy_addr, MII_STATUS);
/* Link ON & Not select default PHY & not ghost PHY */
- if ((status & MII_STAT_LINK) && !default_phy &&
- (phy->phy_types != UNKNOWN))
- default_phy = phy;
- else {
+ if ((status & MII_STAT_LINK) && !default_phy &&
+ (phy->phy_types != UNKNOWN)) {
+ default_phy = phy;
+ } else {
status = mdio_read(net_dev, phy->phy_addr, MII_CONTROL);
mdio_write(net_dev, phy->phy_addr, MII_CONTROL,
status | MII_CNTL_AUTO | MII_CNTL_ISOLATE);
@@ -741,7 +741,7 @@ static u16 sis900_default_phy(struct net_device * net_dev)
phy_home = phy;
else if(phy->phy_types == LAN)
phy_lan = phy;
- }
+ }
}
if (!default_phy && phy_home)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: sis900: fix indentation issues, remove some spaces
2019-03-14 23:56 [PATCH] net: sis900: fix indentation issues, remove some spaces Colin King
@ 2019-03-15 18:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-15 18:59 UTC (permalink / raw)
To: colin.king; +Cc: venza, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 14 Mar 2019 23:56:35 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several statements that contain extra spacing in
> the indentation; clean this up by removing spaces. Also
> add { } braces on if statement to keep to kernel coding
> style.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-15 18:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-14 23:56 [PATCH] net: sis900: fix indentation issues, remove some spaces Colin King
2019-03-15 18:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).