From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Quentin Monnet <quentin.monnet@netronome.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Martin KaFai Lau <kafai@fb.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Song Liu <songliubraving@fb.com>,
Stanislav Fomichev <sdf@google.com>, Yonghong Song <yhs@fb.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] bpftool: Allow referring to maps by its name
Date: Fri, 15 Mar 2019 13:18:53 -0700 [thread overview]
Message-ID: <20190315131853.13f45a70@cakuba.netronome.com> (raw)
In-Reply-To: <20190315195142.GB22548@kernel.org>
On Fri, 15 Mar 2019 16:51:42 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 15, 2019 at 12:16:32PM -0700, Jakub Kicinski escreveu:
> > Please do keep the current model of name val, IOW dump map *name* pids..
>
> I don't have a problem with that, but what would be the problem with
> supporting both:
>
> bpftool map dump name pids_filtered
>
> and:
>
> bpftool map dump pids_filtered
>
> And for that matter, even:
>
> bpftool map dump id 30
>
> And
>
> bpftool map dump 30
>
> Ditto for 'pinned'?
>
> I.e. less typing, the tool can be smart enough to figure out what is
> that is being asked, i.e. is it a number? Try first it as an 'id', etc.
It's error prone, we have excellent bash completions and accept
prefixing (bpftool m d n pids_filtered), so typing should not be
a problem.
prev parent reply other threads:[~2019-03-15 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 18:41 [PATCH 1/1] bpftool: Allow referring to maps by its name Arnaldo Carvalho de Melo
2019-03-15 19:16 ` Jakub Kicinski
2019-03-15 19:41 ` Quentin Monnet
2019-03-15 19:48 ` Arnaldo Carvalho de Melo
2019-03-15 20:25 ` Jakub Kicinski
2019-03-15 19:51 ` Arnaldo Carvalho de Melo
2019-03-15 20:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315131853.13f45a70@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=acme@redhat.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=quentin.monnet@netronome.com \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).