From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB9AC43381 for ; Fri, 15 Mar 2019 15:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94E3221871 for ; Fri, 15 Mar 2019 15:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729309AbfCOPZg (ORCPT ); Fri, 15 Mar 2019 11:25:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38366 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726792AbfCOPZg (ORCPT ); Fri, 15 Mar 2019 11:25:36 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE4817AEB8; Fri, 15 Mar 2019 15:25:35 +0000 (UTC) Received: from elisabeth (ovpn-200-27.brq.redhat.com [10.40.200.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D2C95D6B3; Fri, 15 Mar 2019 15:25:24 +0000 (UTC) Date: Fri, 15 Mar 2019 16:25:09 +0100 From: Stefano Brivio To: Zhiqiang Liu Cc: , , , , , , Mingfangsen , "Zhoukang (A)" , "wangxiaogang (F)" , Eric Dumazet Subject: Re: [PATCH] vxlan: remove the redundant gro_cells_destroy() calling. Message-ID: <20190315162509.738ceb4d@elisabeth> In-Reply-To: <3cf8fd2c-d0c0-0a22-d5d2-fe285bb628b0@huawei.com> References: <2276c137-d5c0-bdbe-f5c7-5985ffc497ce@huawei.com> <20190315125434.093afbd1@elisabeth> <3cf8fd2c-d0c0-0a22-d5d2-fe285bb628b0@huawei.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 15 Mar 2019 15:25:35 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 15 Mar 2019 22:55:52 +0800 Zhiqiang Liu wrote: > > On Fri, 15 Mar 2019 18:06:45 +0800 > > Zhiqiang Liu wrote: > > > >> From: "Suanming.Mou" > >> > >> With ad6c9986bcb6, GRO cells will be destroyed in vxlan_uninit. > > > > Thanks for cleaning this up. > > > > I think it would be nice if you could actually explain in the commit > > message why this makes the call in vxlan_destroy_tunnels() redundant. > > > Thanks for your reply. Actually, the patch is a cleanup as you said. > In vxlan_destroy_tunnels func, unregister_netdevice_queue is called after gro_cells_destroy > func. However, in unregister_netdevice_queue func, the gro_cells_destroy func will also call > the gro_cells_destroy func as the following routine: > unregister_netdevice_many -> rollback_registered_many -> ndo_uninit -> gro_cells_destroy Yes, I think this is exactly what you should add in the commit message of v2. > Fortunately, gro_cells_destroy func will check whether gcells->cells is NULL, so even more than > one call gro_cells_destroy would not cause the memory twice-free problem. > > >> Fixes: ad6c9986bcb6 ("vxlan: Fix GRO cells race condition between receive and link delete") > > > > I'm not sure a Fixes: tag is appropriate here (and also if this > > shouldn't be targeted for net-next) -- in the end, gro_cells_destroy() > > there would just return: > > > > if (!gcells->cells) > > return; > > > >> Signed-off-by: Suanming.Mou > > As you said, this is just a cleanup. I will remove the Fixes tag in v2 patch. > I used the ./scripts/get_maintainer.pl to get the maintainers and mail-list, and the return is > given as follows, > > [...] That's correct, you sent the patch to the right addresses. But there are two trees for networking, net and net-next. See: "Q: How do I indicate which tree (net vs. net-next) my patch should be in?" in Documentation/networking/netdev-FAQ.rst (perhaps you should also read the whole thing while at it). Mind that net-next is currently closed, so you'll have to wait a bit. -- Stefano