From: Stefano Brivio <sbrivio@redhat.com>
To: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc: <davem@davemloft.net>, <petrm@mellanox.com>,
<idosch@mellanox.com>, <sd@queasysnail.net>,
<mousuanming@huawei.com>, <netdev@vger.kernel.org>,
Mingfangsen <mingfangsen@huawei.com>,
"Zhoukang (A)" <zhoukang7@huawei.com>,
"wangxiaogang (F)" <wangxiaogang3@huawei.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2] vxlan: remove the redundant gro_cells_destroy() calling.
Date: Fri, 15 Mar 2019 16:28:24 +0100 [thread overview]
Message-ID: <20190315162824.732b18ac@elisabeth> (raw)
In-Reply-To: <e733fd70-df29-5007-d514-fc487741725b@huawei.com>
On Fri, 15 Mar 2019 23:18:52 +0800
Zhiqiang Liu <liuzhiqiang26@huawei.com> wrote:
> In vxlan_destroy_tunnels func, unregister_netdevice_queue is called after
> gro_cells_destroy func. However, in unregister_netdevice_queue func, the
> gro_cells_destroy func will also call the gro_cells_destroy func as the
> following routine:
> unregister_netdevice_many() -> rollback_registered_many()
> -> ndo_uninit() -> gro_cells_destroy()
>
> Signed-off-by: Suanming.Mou <mousuanming@huawei.com>
> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
NACK, please read my and Eric's comments to v1 -- giving me more than 23
minutes to answer would have been a nice touch as well :)
--
Stefano
next prev parent reply other threads:[~2019-03-15 15:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 10:06 [PATCH] vxlan: remove the redundant gro_cells_destroy() calling Zhiqiang Liu
2019-03-15 11:54 ` Stefano Brivio
2019-03-15 14:55 ` Zhiqiang Liu
2019-03-15 15:25 ` Stefano Brivio
2019-03-15 14:58 ` Eric Dumazet
2019-03-15 15:18 ` [PATCH v2] " Zhiqiang Liu
2019-03-15 15:28 ` Stefano Brivio [this message]
2019-03-15 16:06 ` Eric Dumazet
2019-03-15 18:02 ` David Miller
2019-03-15 18:56 ` Eric Dumazet
2019-03-15 21:08 ` Stefano Brivio
2019-03-15 21:26 ` Eric Dumazet
2019-03-15 22:04 ` Stefano Brivio
2019-03-16 5:24 ` Zhiqiang Liu
2019-03-16 5:45 ` Stefano Brivio
2019-03-16 6:27 ` Zhiqiang Liu
2019-03-16 2:33 ` Zhiqiang Liu
2019-03-16 9:02 ` [PATCH net v3] vxlan: Don't call gro_cells_destroy() before device is unregistered Zhiqiang Liu
2019-03-19 0:08 ` David Miller
2019-03-15 18:02 ` [PATCH v2] vxlan: remove the redundant gro_cells_destroy() calling David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315162824.732b18ac@elisabeth \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=idosch@mellanox.com \
--cc=liuzhiqiang26@huawei.com \
--cc=mingfangsen@huawei.com \
--cc=mousuanming@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=sd@queasysnail.net \
--cc=wangxiaogang3@huawei.com \
--cc=zhoukang7@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).