From: Jiri Olsa <jolsa@redhat.com>
To: Changbin Du <changbin.du@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
namhyung@kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>,
rostedt@goodmis.org, Daniel Borkmann <daniel@iogearbox.net>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 00/16] fix some perf issues detected by ASan
Date: Mon, 18 Mar 2019 11:08:12 +0100 [thread overview]
Message-ID: <20190318100812.GC28556@krava> (raw)
In-Reply-To: <20190316080556.3075-1-changbin.du@gmail.com>
On Sat, Mar 16, 2019 at 04:05:40PM +0800, Changbin Du wrote:
> AddressSanitizer (or ASan) and UndefinedBehaviorSanitizer (or UBSan) are
> very useful tools to detect program bugs. This series fixed some issues
> disclosed by ASan.
>
> AddressSanitizer (or ASan) is a GCC feature that detects memory corruption bugs
> such as buffer overflows or memory leaks.
> $ cd tools/perf
> $ make DEBUG=1 EXTRA_CFLAGS='-fno-omit-frame-pointer -fsanitize=address'
> $ ASAN_OPTIONS=log_path=asan.log ./perf record -a
> ASan outputs all detected issues into log file 'asan.log.<pid>'.
>
> Note that this only fixes parts of the detected issues. There are many remaining
> to be fixed[1].
>
> [1] http://104.238.181.70:8080/asan.log.32555.txt
>
> Changbin Du (16):
> perf: add doc for how to build perf with Asan and UBSan
> perf: list: fix memory leak in function is_event_supported
> perf: fix errors under optimization level '-Og'
> perf: fix an error in config template
> perf: fix a memory leak in collect_config
> perf: fix memory leak in print_sdt_events()
> perf: top: fix heap-use-after-free issue
> perf: top: fix error handing in cmd_top()
> perf: missed a map__put() in error case
> perf: remove map from names tree in __maps__remove
> perf: purge all maps from the names tree
> perf: top: fix global-buffer-overflow issue
> perf: free all counts in perf_evsel__exit
> perf: fix a memory leak of cpu_map object
> perf: fix memory leak by expr__find_other
> perf: fix a memory leak in test__perf_evsel__tp_sched_test
awesome.. thanks a lot
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
jirka
>
> tools/lib/bpf/libbpf.c | 2 +-
> tools/perf/Documentation/Build.txt | 20 +++++++++
> tools/perf/Documentation/perf-config.txt | 2 +-
> tools/perf/bench/epoll-ctl.c | 2 +-
> tools/perf/bench/epoll-wait.c | 2 +-
> tools/perf/builtin-top.c | 47 ++++++++++------------
> tools/perf/tests/backward-ring-buffer.c | 2 +-
> tools/perf/tests/evsel-tp-sched.c | 1 +
> tools/perf/tests/expr.c | 5 ++-
> tools/perf/tests/openat-syscall-all-cpus.c | 4 +-
> tools/perf/util/build-id.c | 1 +
> tools/perf/util/config.c | 3 +-
> tools/perf/util/counts.c | 18 +++++++++
> tools/perf/util/counts.h | 4 ++
> tools/perf/util/evsel.c | 2 +
> tools/perf/util/hist.c | 4 +-
> tools/perf/util/map.c | 18 +++++++++
> tools/perf/util/ordered-events.c | 2 +
> tools/perf/util/parse-events.c | 2 +
> tools/perf/util/stat.c | 18 ---------
> 20 files changed, 106 insertions(+), 53 deletions(-)
>
> --
> 2.19.1
>
next prev parent reply other threads:[~2019-03-18 10:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 8:05 [PATCH 00/16] fix some perf issues detected by ASan Changbin Du
2019-03-16 8:05 ` [PATCH 01/16] perf: add doc for how to build perf with Asan and UBSan Changbin Du
2019-03-18 10:07 ` Jiri Olsa
2019-03-18 20:08 ` Arnaldo Carvalho de Melo
2019-03-20 12:00 ` Changbin Du
2019-03-20 11:58 ` Changbin Du
2019-03-16 8:05 ` [PATCH 02/16] perf: list: fix memory leak in function is_event_supported Changbin Du
2019-03-16 8:05 ` [PATCH 03/16] perf: fix errors under optimization level '-Og' Changbin Du
2019-03-16 8:05 ` [PATCH 04/16] perf: fix an error in config template Changbin Du
2019-03-16 8:05 ` [PATCH 05/16] perf: fix a memory leak in collect_config Changbin Du
2019-03-16 8:05 ` [PATCH 06/16] perf: fix memory leak in print_sdt_events() Changbin Du
2019-03-16 8:05 ` [PATCH 07/16] perf: top: fix heap-use-after-free issue Changbin Du
2019-03-18 10:08 ` Jiri Olsa
2019-03-16 8:05 ` [PATCH 08/16] perf: top: fix error handing in cmd_top() Changbin Du
2019-03-16 8:05 ` [PATCH 09/16] perf: missed a map__put() in error case Changbin Du
2019-03-16 8:05 ` [PATCH 10/16] perf: remove map from names tree in __maps__remove Changbin Du
2019-03-16 8:05 ` [PATCH 11/16] perf: purge all maps from the names tree Changbin Du
2019-03-16 8:05 ` [PATCH 12/16] perf: top: fix global-buffer-overflow issue Changbin Du
2019-03-16 8:05 ` [PATCH 13/16] perf: free all counts in perf_evsel__exit Changbin Du
2019-03-18 19:39 ` Arnaldo Carvalho de Melo
2019-03-16 8:05 ` [PATCH 14/16] perf: fix a memory leak of cpu_map object Changbin Du
2019-03-16 8:05 ` [PATCH 15/16] perf: fix memory leak by expr__find_other Changbin Du
2019-03-16 8:05 ` [PATCH 16/16] perf: fix a memory leak in test__perf_evsel__tp_sched_test Changbin Du
2019-03-18 10:08 ` Jiri Olsa [this message]
2019-03-18 16:16 ` [PATCH 00/16] fix some perf issues detected by ASan Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318100812.GC28556@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=changbin.du@gmail.com \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).