From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B65C43381 for ; Mon, 18 Mar 2019 19:59:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEE3520857 for ; Mon, 18 Mar 2019 19:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="1em2boPU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727000AbfCRT7m (ORCPT ); Mon, 18 Mar 2019 15:59:42 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:39794 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726776AbfCRT7l (ORCPT ); Mon, 18 Mar 2019 15:59:41 -0400 Received: by mail-qt1-f196.google.com with SMTP id t28so19500120qte.6 for ; Mon, 18 Mar 2019 12:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=+VoBHbVr9zoa9rScngCuKMXI89LnlPLsjBzE+I4raPI=; b=1em2boPUoAqTgMMd1hJWjVB7uFq5uPBFvSavLlmuY3URpoBw09WIK/P2grUQUHt8Mf 157SK/jsHjJLn+Bks2qujNdCcCdulynWihKw5h4VE51cWgPuLoUHJLa4NW9COtC6qrjY pT0vcz2srWJAOx76GGO7P8dO2JMY1dCsGQD5KQSHZeeagc6t+CN8Q5NWL64M0n2+wIN3 NFitMoxipqV/0Ek0uqNmhXJFULmtcSRrtnPcG+6GRmSPWPFEQbKcykyareYgM3w05/8O Bk+oAIX/ZIeB93RAePsKKKGT1e0m2cVcvbMRD0dVZjM6nrfmdYjnCsKDrxRqdCrt/fr0 c0AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=+VoBHbVr9zoa9rScngCuKMXI89LnlPLsjBzE+I4raPI=; b=LuGvnASmWmw0GBejDbASEPD8Kcw6/vHtl2EqdwDqEbVKAdF2w9WTaoLbQXRnXDX1ec 5P4OBQhZSKnx0bK6AiQ6xZWZyl2CChbuyFJVDDck+xKqhW3CHrbayMRxYNCSg1Iu/al1 qQfp+NULiuelttPLKNbS8amkjdb8tAELCeghyFxNCxit0h0hbjsQbnZ8IiNkT4+0Qi+6 nnXqtEgrqbZmNFBJH0bv7yNv/pw3dZ52iS/REfU87dpzRWXTR2C3sm9FmOCE5jiSi0O3 Le0osDWGNn6K+g2EQ9RxoyV7wtg/Kh5d7IUpHmo1tXBTNh2dZjavQENansXrTcpJWZej LtKQ== X-Gm-Message-State: APjAAAWDLXNDrC6GNyXkxKW6+o0PpBm8+IYWXIUTYH4EwHID6NxDE+Lc ulmY/TjxK88eaWS6Mi+O06HiQA== X-Google-Smtp-Source: APXvYqxFbyCSXoWfJATHTlzXf8QdmGlQBEk/DFFdCDRHAazr+tA4lZ95SIfOmZAXhncOT4n2LZo1tw== X-Received: by 2002:ac8:6ce:: with SMTP id j14mr14685564qth.47.1552939180465; Mon, 18 Mar 2019 12:59:40 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id a47sm3288415qtb.79.2019.03.18.12.59.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 12:59:40 -0700 (PDT) Date: Mon, 18 Mar 2019 12:59:35 -0700 From: Jakub Kicinski To: Parav Pandit Cc: Jiri Pirko , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190318125935.580c8fbe@cakuba.netronome.com> In-Reply-To: References: <20190314150945.031d1b08@cakuba.netronome.com> <20190314163915.24fd2481@cakuba.netronome.com> <4436da3d-4b99-f792-8e77-695d5958794d@intel.com> <20190315200814.GD2305@nanopsycho> <20190318122105.GH2270@nanopsycho> <20190318123634.6e90c043@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 18 Mar 2019 19:44:21 +0000, Parav Pandit wrote: > > -----Original Message----- > > From: Jakub Kicinski > > Sent: Monday, March 18, 2019 2:37 PM > > To: Parav Pandit > > Cc: Jiri Pirko ; Samudrala, Sridhar > > ; davem@davemloft.net; > > netdev@vger.kernel.org; oss-drivers@netronome.com > > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI > > ports > > > > On Mon, 18 Mar 2019 16:22:33 +0000, Parav Pandit wrote: > > >>>>>>2. flavour should not be vf/pf, flavour should be hostport, switchport. > > >>> >Because switch is flat and agnostic of pf/vf/mdev. > > >>>>> > > >>>>> Not sure. It's good to have this kind of visibility. > > >>>>> > > >>>> port can have label/attribute indicating that this belong to VF-1 > > >>>> or mdev as long as you are agreeing to have mdev attribute on host port. > > >>>> (and not ask for abstracting it, because mdev is well defined kernel object). > > >>> > > >>> Why mdev cannot be another flavour? > > >>> > > >> > > >> hostport is of type pf/vf/mdev connected to some switchport. > > >> > > >> So proposal is to have, > > >> port flavour = hostport/switchport > > >> port type/label = pf/vf/mdev > > >> > > > Instead of having two attributes per port, how about having, port > > > flavour= physical/cpu/dsa/pf/vf/mdev/switchport. > > > > > > physical and pf has some overlapping definitions. > > > > What "overlapping definitions" do physical and PF have? > PF has physically user facing port. PF doesn't "have a user facing port" in switchdev mode. It's a limitation of Mellanox HW that you have some strong association there. > And physical port in include/uapi/linux/devlink.h also describe that. By "that" you must mean that the physical is a user facing port.