From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=pZ4W=RV=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7090CC43381
	for <netdev@archiver.kernel.org>; Mon, 18 Mar 2019 13:12:09 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 36C7F20863
	for <netdev@archiver.kernel.org>; Mon, 18 Mar 2019 13:12:09 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="52gJ59Sz"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727529AbfCRNMI (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 18 Mar 2019 09:12:08 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:57370 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726691AbfCRNMH (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 18 Mar 2019 09:12:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=86QxPFvJ204RryMQJen0rc6Qw4VwmNTNkvdD+b2MyTE=; b=52gJ59Szeh4RtykbKTGROFbC3F
        bRXEyudTLJbuvMLRfumnD+tWGPSJiv3Ek0sd1269ldQ3jAqe3doznt4sEjCnKjWhBSHXAPQa5iuvW
        lAjZ2Jh6/q7ZTbltvldqj+oyFIZzogy+Noi7EM1VAWYZraLHTKLUgmZBQ09oM5PXQmpQ=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1h5s3f-0004dC-DE; Mon, 18 Mar 2019 14:12:03 +0100
Date:   Mon, 18 Mar 2019 14:12:03 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Petr Machata <petrm@mellanox.com>
Cc:     Jakub Kicinski <jakub.kicinski@netronome.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jiri Pirko <jiri@mellanox.com>,
        Ido Schimmel <idosch@mellanox.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Tariq Toukan <tariqt@mellanox.com>,
        "stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [RFC PATCH net-next 1/3] net: rtnetlink: Add link-down reason to
 RTNL messages
Message-ID: <20190318131203.GD30224@lunn.ch>
References: <cover.1552672441.git.petrm@mellanox.com>
 <3a247e91ebe81cdae4bae27ec1631c5015fb943f.1552672441.git.petrm@mellanox.com>
 <20190315192611.3354f9b5@cakuba.netronome.com>
 <871s34icnr.fsf@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871s34icnr.fsf@mellanox.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> This copies how other fill APIs are done, in that the responsibility for
> filling up the message is deferred to the driver. I think it makes the
> API easier to extend: if there ever is richer information available, the
> drivers that want to support it just opt in and provide those attributes.

Hi Petr

Actually, if you look at the PHY layer, none of the drivers have
anything to do with netlink messages. Nor does the phylib or phylink
core. It all happens a layer above. I would keep the API to the driver
simple, just ask it for two u32, and do all the netlink conversion in
the core.

    Andrew