From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF618C43381 for ; Mon, 18 Mar 2019 22:55:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2F1D20989 for ; Mon, 18 Mar 2019 22:55:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="IKdnQoG7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727304AbfCRWzQ (ORCPT ); Mon, 18 Mar 2019 18:55:16 -0400 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:53398 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726831AbfCRWzQ (ORCPT ); Mon, 18 Mar 2019 18:55:16 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 3207117C for ; Mon, 18 Mar 2019 22:55:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lsPcMGNzBRXm for ; Mon, 18 Mar 2019 17:55:15 -0500 (CDT) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 066FFB49 for ; Mon, 18 Mar 2019 17:55:15 -0500 (CDT) Received: by mail-io1-f70.google.com with SMTP id z6so14195287ioh.16 for ; Mon, 18 Mar 2019 15:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=ekgEiSdzFq4TTcMvB4m0KnKmaQJ4Bt4kfyIC02uEVFE=; b=IKdnQoG783bjQDMPkChNhU+904HcFtJY8kRv5M/NTbdsRypmK2Ha3Dfg3Fa4YB4ivA rtJKB9uVZSyNrPxOOau+pynu2nWK2lNxBlAqoL5tilzmZZki2RcPLyg//oOA/fXqiUFC hTk6H9PAZoIVyQRdzgt+SQAFdLI2AwaVCGoaLw3bDb051k/zc9TXxGv8vola2Ivi6B5e GLn06PkDXZ/hz5Jk+Q4LuMTdJQQQtirp8iBy19EKJKJGLxzvxZR7jwT5/wbv/KbQi59W 16IQeXYtCCrhrol6iYDJts1x+S1BUg562BfLP1km01j48USerurH7efwVqA6fW83PYH6 nwsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ekgEiSdzFq4TTcMvB4m0KnKmaQJ4Bt4kfyIC02uEVFE=; b=p2cv+i99WpZFhJB6DXmgnmvd+OGHd5rUjV89ka8TzrS3uT+BuWUMkMIq9O4sESIUtG jp5FKZveLJjj6ZI2/InlZVPvZhz0ZMQTbiMl5F3mDpAFo6YO0TUxvXYqzgnEveinXdcL QJ7IrZuNxDq+Ka80rcT9fYBAWikKlTFFu2PBJqyTNa5kISSD/SAIJ7RRrQlB0KRT5Y9Y A9Ceh2xMADt/tleA80rtavTfirNgHvs0Qm2AIeC1PGfnMes8RB1qvoEnKzBTQu6iRpO7 kNHcAE9y7wnGGleR4kh8DEdljmB23D3moIIOUnItqO9axUDT+D1n49n1OW8MoNEM7ENs vq9Q== X-Gm-Message-State: APjAAAXcssGGHQ32EvPQCR8/9rSq1Ifi3pBQpjx5ZGjfJD0u+xZzPRxr tB4jfbypwQBXrUpL0/b0EB079KG2n6VWMviNOp02oTN2gjsMs/2Gyf7D3m6BVDLZhugQDpCKuHc gAeABpgWgL4CgDr0P1/Lx X-Received: by 2002:a05:660c:2ca:: with SMTP id j10mr825124itd.151.1552949714623; Mon, 18 Mar 2019 15:55:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqx1cC/KD1WTqoDDUMD3Ij2/KGLEj/VcgMi062V38Pod0ZpngskU1Qbco3YesIwR1VV7jNdo0g== X-Received: by 2002:a05:660c:2ca:: with SMTP id j10mr825100itd.151.1552949714026; Mon, 18 Mar 2019 15:55:14 -0700 (PDT) Received: from lenovo-1.hsd1.mn.comcast.net (c-73-242-25-233.hsd1.mn.comcast.net. [73.242.25.233]) by smtp.googlemail.com with ESMTPSA id y3sm403420itb.2.2019.03.18.15.55.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 15:55:13 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH] thunderbolt: xdomain: Fix to check return value of kmemdup Date: Mon, 18 Mar 2019 17:55:08 -0500 Message-Id: <20190318225508.7886-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org kmemdup can fail and return a NULL pointer. The patch modifies the signature of tb_xdp_schedule_request and passes the failure error upstream. Signed-off-by: Aditya Pakki --- drivers/thunderbolt/xdomain.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c index e27dd8beb94b..b0e9cc30d708 100644 --- a/drivers/thunderbolt/xdomain.c +++ b/drivers/thunderbolt/xdomain.c @@ -526,7 +526,7 @@ static void tb_xdp_handle_request(struct work_struct *work) kfree(xw); } -static void +static bool tb_xdp_schedule_request(struct tb *tb, const struct tb_xdp_header *hdr, size_t size) { @@ -534,13 +534,16 @@ tb_xdp_schedule_request(struct tb *tb, const struct tb_xdp_header *hdr, xw = kmalloc(sizeof(*xw), GFP_KERNEL); if (!xw) - return; + return false; INIT_WORK(&xw->work, tb_xdp_handle_request); xw->pkg = kmemdup(hdr, size, GFP_KERNEL); + if (!xw->pkg) + return false; xw->tb = tb; queue_work(tb->wq, &xw->work); + return true; } /** @@ -1417,8 +1420,7 @@ bool tb_xdomain_handle_request(struct tb *tb, enum tb_cfg_pkg_type type, */ if (uuid_equal(&hdr->uuid, &tb_xdp_uuid)) { if (type == TB_CFG_PKG_XDOMAIN_REQ) { - tb_xdp_schedule_request(tb, hdr, size); - return true; + return tb_xdp_schedule_request(tb, hdr, size); } return false; } -- 2.17.1