From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Eric Dumazet <edumazet@google.com>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tcp: don't use __constant_cpu_to_be32
Date: Tue, 19 Mar 2019 10:29:14 +0900 [thread overview]
Message-ID: <20190319012914.GA9313@jagdpanzerIV> (raw)
In-Reply-To: <20190318163208.GC7431@mini-arch.hsd1.ca.comcast.net>
On (03/18/19 09:32), Stanislav Fomichev wrote:
[..]
> > -#define bpf_htons(x) \
> > - (__builtin_constant_p(x) ? \
> > - __bpf_constant_htons(x) : __bpf_htons(x))
> > -#define bpf_ntohs(x) \
> > - (__builtin_constant_p(x) ? \
> > - __bpf_constant_ntohs(x) : __bpf_ntohs(x))
> > -#define bpf_htonl(x) \
> > - (__builtin_constant_p(x) ? \
> > - __bpf_constant_htonl(x) : __bpf_htonl(x))
> > -#define bpf_ntohl(x) \
> > - (__builtin_constant_p(x) ? \
> > - __bpf_constant_ntohl(x) : __bpf_ntohl(x))
> > +#define bpf_htons(x) __bpf_htons((x))
> > +#define bpf_ntohs(x) __bpf_ntohs((x))
> > +#define bpf_htonl(x) __bpf_htonl((x))
> > +#define bpf_ntohl(x) __bpf_ntohl((x))
> At this point we can probably drop __bpf_xxx as well?
> Care to resend with proper description when bpf-next opens?
OK.
-ss
next prev parent reply other threads:[~2019-03-19 1:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 6:15 [PATCH] tcp: don't use __constant_cpu_to_be32 Sergey Senozhatsky
2019-03-14 12:42 ` Eric Dumazet
2019-03-15 1:20 ` Sergey Senozhatsky
2019-03-15 17:24 ` Stanislav Fomichev
2019-03-16 5:19 ` Sergey Senozhatsky
2019-03-16 7:18 ` Sergey Senozhatsky
2019-03-16 14:26 ` Sergey Senozhatsky
2019-03-18 16:32 ` Stanislav Fomichev
2019-03-19 1:29 ` Sergey Senozhatsky [this message]
2019-03-18 16:28 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319012914.GA9313@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).