netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wang Hai <wanghai26@huawei.com>
Cc: davem@davemloft.net, idosch@mellanox.com,
	alexander.h.duyck@intel.com, tyhicks@canonical.com,
	f.fainelli@gmail.com, amritha.nambiar@intel.com, joe@perches.com,
	dmitry.torokhov@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net-sysfs: Fix memory leak in netdev_register_kobject
Date: Tue, 19 Mar 2019 12:31:33 +0200	[thread overview]
Message-ID: <20190319103133.GE9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190319213613.48888-1-wanghai26@huawei.com>

On Tue, Mar 19, 2019 at 05:36:13PM -0400, Wang Hai wrote:
> When registering struct net_device, it will call
> 	register_netdevice ->
> 		netdev_register_kobject ->
> 			dev_set_name(dev, "%s", ndev->name)
> 			device_add(dev)
> 			register_queue_kobjects(ndev)
> 

>  - Improve the description of the cause of the bug, no code changes.

See my previous message.
NAK for this.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2019-03-19 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 21:36 [PATCH v2] net-sysfs: Fix memory leak in netdev_register_kobject Wang Hai
2019-03-19 10:31 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190319103133.GE9224@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=amritha.nambiar@intel.com \
    --cc=davem@davemloft.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tyhicks@canonical.com \
    --cc=wanghai26@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).