netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: "Su Yanjun <suyj.fnst@cn.fujitsu.com>" <suyj.fnst@cn.fujitsu.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, <davem@davemloft.net>,
	<fw@strlen.de>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm
Date: Wed, 20 Mar 2019 18:16:22 +0100	[thread overview]
Message-ID: <20190320171622.GA6035@gauss3.secunet.de> (raw)
In-Reply-To: <91cf303a-7d44-2c15-8b7a-8b2eb797a234@cn.fujitsu.com>

On Wed, Mar 20, 2019 at 08:53:54AM +0800, Su Yanjun <suyj.fnst@cn.fujitsu.com> wrote:
> 
> Firs of all, I didn't produce it on my test machine.

First of all, you should provide better quality patches.

All of your recent patches had issues, some were sorted 
out before applying other not. Bugs happen, but it is
not acceptable that all your patches are buggy.

I've reverted this patch like Eric suggested.

      reply	other threads:[~2019-03-20 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07  1:54 [PATCH v3] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm Su Yanjun
2019-03-11 10:10 ` Steffen Klassert
2019-03-18 17:22   ` Eric Dumazet
2019-03-19 15:15     ` Steffen Klassert
2019-03-19 15:52       ` Eric Dumazet
2019-03-20  0:53       ` Su Yanjun <suyj.fnst@cn.fujitsu.com>
2019-03-20 17:16         ` Steffen Klassert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190320171622.GA6035@gauss3.secunet.de \
    --to=steffen.klassert@secunet.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=fw@strlen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=suyj.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).