From: David Miller <davem@davemloft.net>
To: hoang.h.le@dektech.com.au
Cc: jon.maloy@ericsson.com, maloy@donjonn.com,
ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [net-next v1 2/2] tipc: fix a null pointer deref
Date: Thu, 21 Mar 2019 09:57:24 -0700 (PDT) [thread overview]
Message-ID: <20190321.095724.966275877142417270.davem@davemloft.net> (raw)
In-Reply-To: <20190321102518.5048-2-hoang.h.le@dektech.com.au>
From: Hoang Le <hoang.h.le@dektech.com.au>
Date: Thu, 21 Mar 2019 17:25:18 +0700
> In commit c55c8edafa91 ("tipc: smooth change between replicast and
> broadcast") we introduced new method to eliminate the risk of message
> reordering that happen in between different nodes.
> Unfortunately, we forgot checking at receiving side to ignore intra node.
>
> We fix this by checking and returning if arrived message from intra node.
>
> syzbot report:
...
> Reported-by: syzbot+be4bdf2cc3e85e952c50@syzkaller.appspotmail.com
> Fixes: c55c8eda ("tipc: smooth change between replicast and broadcast")
> Acked-by: Jon Maloy <jon.maloy@ericsson.com>
> Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Applied.
next prev parent reply other threads:[~2019-03-21 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 10:25 [net-next v1 1/2] tipc: fix use-after-free in tipc_sk_filter_rcv Hoang Le
2019-03-21 10:25 ` [net-next v1 2/2] tipc: fix a null pointer deref Hoang Le
2019-03-21 16:57 ` David Miller [this message]
2019-03-21 16:57 ` [net-next v1 1/2] tipc: fix use-after-free in tipc_sk_filter_rcv David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321.095724.966275877142417270.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hoang.h.le@dektech.com.au \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).