From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F72C43381 for ; Thu, 21 Mar 2019 17:14:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 405E821900 for ; Thu, 21 Mar 2019 17:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728643AbfCUROs (ORCPT ); Thu, 21 Mar 2019 13:14:48 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50552 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727987AbfCUROr (ORCPT ); Thu, 21 Mar 2019 13:14:47 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 32DD3133E976A; Thu, 21 Mar 2019 10:14:47 -0700 (PDT) Date: Thu, 21 Mar 2019 10:14:46 -0700 (PDT) Message-Id: <20190321.101446.1564915695715800942.davem@davemloft.net> To: vakul.garg@nxp.com Cc: netdev@vger.kernel.org, borisp@mellanox.com, aviadye@mellanox.com, davejwatson@fb.com, doronrk@fb.com Subject: Re: [PATCH net-next v2 1/1] net/tls: Replace kfree_skb() with consume_skb() From: David Miller In-Reply-To: <20190321115710.4343-1-vakul.garg@nxp.com> References: <20190321115710.4343-1-vakul.garg@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Mar 2019 10:14:47 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vakul Garg Date: Thu, 21 Mar 2019 11:59:57 +0000 > To free the skb in normal course of processing, consume_skb() should be > used. Only for failure paths, skb_free() is intended to be used. > > https://www.kernel.org/doc/htmldocs/networking/API-consume-skb.html > > Signed-off-by: Vakul Garg > --- > v1 -> v2: > Reverted consume_skb() to kfree_skb() in tls_sw_release_resources_rx() Applied.