From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C2FC43381 for ; Thu, 21 Mar 2019 20:19:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB681218D3 for ; Thu, 21 Mar 2019 20:19:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728615AbfCUUT3 (ORCPT ); Thu, 21 Mar 2019 16:19:29 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52668 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727909AbfCUUT3 (ORCPT ); Thu, 21 Mar 2019 16:19:29 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3868E133FB70F; Thu, 21 Mar 2019 13:19:28 -0700 (PDT) Date: Thu, 21 Mar 2019 13:19:27 -0700 (PDT) Message-Id: <20190321.131927.1229577878872009929.davem@davemloft.net> To: ktkhai@virtuozzo.com Cc: netdev@vger.kernel.org, harald.albrecht@gmx.net, jasowang@redhat.com, brouer@redhat.com, edumazet@google.com, mst@redhat.com, nicolas.dichtel@6wind.com, wangli39@baidu.com Subject: Re: [PATCH 1/2] tun: Add ioctl() TUNGETDEVNETNS cmd to allow obtaining real net ns of tun device From: David Miller In-Reply-To: <155307337803.17673.7357500798893442953.stgit@localhost.localdomain> References: <155307337803.17673.7357500798893442953.stgit@localhost.localdomain> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Mar 2019 13:19:28 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Kirill Tkhai Date: Wed, 20 Mar 2019 12:16:42 +0300 > In commit f2780d6d7475 "tun: Add ioctl() SIOCGSKNS cmd to allow > obtaining net ns of tun device" it was missed that tun may change > its net ns, while net ns of socket remains the same as it was > created initially. SIOCGSKNS returns net ns of socket, so it is > not suitable for obtaining net ns of device. > > We may have two tun devices with the same names in two net ns, > and in this case it's not possible to determ, which of them > fd refers to (TUNGETIFF will return the same name). > > This patch adds new ioctl() cmd for obtaining net ns of a device. > > Reported-by: Harald Albrecht > Signed-off-by: Kirill Tkhai Applied.