From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97CBDC43381 for ; Thu, 21 Mar 2019 20:39:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E8F42183E for ; Thu, 21 Mar 2019 20:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728868AbfCUUjq (ORCPT ); Thu, 21 Mar 2019 16:39:46 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53008 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728775AbfCUUjq (ORCPT ); Thu, 21 Mar 2019 16:39:46 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F03D1133E9775; Thu, 21 Mar 2019 13:39:44 -0700 (PDT) Date: Thu, 21 Mar 2019 13:39:44 -0700 (PDT) Message-Id: <20190321.133944.1484834118085536102.davem@davemloft.net> To: wanghai26@huawei.com Cc: idosch@mellanox.com, alexander.h.duyck@intel.com, tyhicks@canonical.com, f.fainelli@gmail.com, amritha.nambiar@intel.com, joe@perches.com, dmitry.torokhov@gmail.com, andriy.shevchenko@linux.intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] net-sysfs: Fix memory leak in netdev_register_kobject From: David Miller In-Reply-To: <20190320182505.18642-1-wanghai26@huawei.com> References: <20190320182505.18642-1-wanghai26@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Mar 2019 13:39:45 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wang Hai Date: Wed, 20 Mar 2019 14:25:05 -0400 > When registering struct net_device, it will call > register_netdevice -> > netdev_register_kobject -> > device_initialize(dev); > dev_set_name(dev, "%s", ndev->name) > device_add(dev) > register_queue_kobjects(ndev) > > In netdev_register_kobject(), if device_add(dev) or > register_queue_kobjects(ndev) failed. Register_netdevice() > will return error, causing netdev_freemem(ndev) to be > called to free net_device, however put_device(&dev->dev)->..-> > kobject_cleanup() won't be called, resulting in a memory leak. > > syzkaller report this: ... > Reported-by: Hulk Robot > Fixes: 1fa5ae857bb1 ("driver core: get rid of struct device's bus_id string array") > Signed-off-by: Wang Hai Applied and queued up for -stable.