From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3E5C43381 for ; Thu, 21 Mar 2019 17:12:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6BFE21900 for ; Thu, 21 Mar 2019 17:12:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728157AbfCURMb (ORCPT ); Thu, 21 Mar 2019 13:12:31 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:42588 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726787AbfCURMb (ORCPT ); Thu, 21 Mar 2019 13:12:31 -0400 Received: by mail-qt1-f194.google.com with SMTP id p20so2029756qtc.9 for ; Thu, 21 Mar 2019 10:12:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jqvGUc71D2n58PMW4aAN/4u2cMhWGsRP45OPkUK920I=; b=fYH5KW58gO7EHccYp+YPaVBDcRMpIRXYOoofatgvlkJqFlw3MjcqTyv14ztH+zoEqU V/xh81GqBqGBhn2HTJP2KC9rUkTraNWZiGT6jNWgLHjYqmFgVli1S56JQ8PKjWvXIi6P 1SuR414Q05fob3XOaJSF7XF8jQrFAoLlso78SNvM0vtiRxetLSJMoIYwWOLDpdWkqc9z boXe3J2cb3JGyfzNiJy+iKp1N9VB4Odd7oHa0t4hwg7cpfcelMXDwOaGGAsY2TItWa+t 6Ai9jywwpWtQ7SoTAT1LrInU8MWG1yOTNXI2JQFs12eXTpxXoWbhRUblOCDq3IQH0L8m pWrg== X-Gm-Message-State: APjAAAXmOf9Cm3jKGkXau39wDZGvGeHp1rBBbnHBXtrjDGnDDv6t4AJx AQNIdlZoLzAaunoqO1fbkJOyLTTQRxej/w== X-Google-Smtp-Source: APXvYqzuk6ORtznB2+cdIB3zpn4Z67ncPuRV1kY88Er/j4R/YRCnY+eiBfD960NTrdy1cql7j80JpA== X-Received: by 2002:ac8:30a1:: with SMTP id v30mr3951175qta.176.1553188350416; Thu, 21 Mar 2019 10:12:30 -0700 (PDT) Received: from redhat.com ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id m4sm2495906qtp.16.2019.03.21.10.12.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 10:12:29 -0700 (PDT) Date: Thu, 21 Mar 2019 13:12:23 -0400 From: "Michael S. Tsirkin" To: Liran Alon Cc: Stephen Hemminger , Si-Wei Liu , Sridhar Samudrala , Alexander Duyck , Jakub Kicinski , Jiri Pirko , David Miller , Netdev , virtualization@lists.linux-foundation.org, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com, jfreimann@redhat.com, ogerlitz@mellanox.com, vuhuong@mellanox.com Subject: Re: [summary] virtio network device failover writeup Message-ID: <20190321131006-mutt-send-email-mst@kernel.org> References: <20190321044920-mutt-send-email-mst@kernel.org> <20190321082532-mutt-send-email-mst@kernel.org> <20190321085159-mutt-send-email-mst@kernel.org> <2939FB15-720A-4C9E-92B7-2DBA139DDE0F@oracle.com> <20190321084517.773a65fa@shemminger-XPS-13-9360> <20190321114557-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 21, 2019 at 06:31:35PM +0200, Liran Alon wrote: > > > > On 21 Mar 2019, at 17:50, Michael S. Tsirkin wrote: > > > > On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote: > >> On Thu, 21 Mar 2019 15:04:37 +0200 > >> Liran Alon wrote: > >> > >>>> > >>>> OK. Now what happens if master is moved to another namespace? Do we need > >>>> to move the slaves too? > >>> > >>> No. Why would we move the slaves? The whole point is to make most customer ignore the net-failover slaves and remain them “hidden” in their dedicated netns. > >>> We won’t prevent customer from explicitly moving the net-failover slaves out of this netns, but we will not move them out of there automatically. > >> > >> > >> The 2-device netvsc already handles case where master changes namespace. > > > > Is it by moving slave with it? > > See c0a41b887ce6 ("hv_netvsc: move VF to same namespace as netvsc device”). > It seems that when NetVSC master netdev changes netns, the VF is moved to the same netns by the NetVSC driver. > Kinda the opposite than what we are suggesting here to make sure that the net-failover master netdev is on a separate > netns than it’s slaves... > > -Liran > > > > > -- > > MST Not exactly opposite I'd say. If failover is in host ns, slaves in /primary and /standby, then moving failover to /container should move slaves to /container/primary and /container/standby. -- MST