From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A49C43381 for ; Thu, 21 Mar 2019 13:41:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0643D2075E for ; Thu, 21 Mar 2019 13:41:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ec4hLKgQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728603AbfCUNlI (ORCPT ); Thu, 21 Mar 2019 09:41:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33383 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728581AbfCUNlG (ORCPT ); Thu, 21 Mar 2019 09:41:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JZTplIzNzibJao90rB/srKiHMTslMoMGGi+iaAxoNhY=; b=ec4hLKgQfsTnmRWz//e5zmB9iV HtLh8pHWBPHhW+IsUK6i8BIpcQK8i7WNipRZYQ8bJOlVl6MKGv1YZs0fDojUHkmzjr9ZxX/ObFbVr b4JxaGTpNnugHTJXh+/VAitBEmpnKSoZ10YUI+suSQNkCe7Vqe8y2WBvmII1GPjY4iVw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h6xwL-0004m2-B9; Thu, 21 Mar 2019 14:41:01 +0100 Date: Thu, 21 Mar 2019 14:41:01 +0100 From: Andrew Lunn To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, vivien.didelot@gmail.com Subject: Re: [patch net-next 09/11] dsa: move devlink_port_attrs_set() call before register Message-ID: <20190321134101.GA17655@lunn.ch> References: <20190321132019.1426-1-jiri@resnulli.us> <20190321132019.1426-10-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321132019.1426-10-jiri@resnulli.us> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 21, 2019 at 02:20:17PM +0100, Jiri Pirko wrote: > + switch (dp->type) { > + case DSA_PORT_TYPE_CPU: > + flavour = DEVLINK_PORT_FLAVOUR_CPU; > + break; > + case DSA_PORT_TYPE_DSA: > + flavour = DEVLINK_PORT_FLAVOUR_DSA; > + break; > + case DSA_PORT_TYPE_USER: /* fall-through */ > + default: > + flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL; > + break; > + } > + > + /* dp->index is used now as port_number. However > + * CPU ports should have separate numbering > + * independent from front panel port numbers. > + */ Hi Jiri Given the way you have rearranged this code, i think the text above should now be: However CPU ports and DSA ports should have separate numbering. Andrew