From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 463A9C43381 for ; Thu, 21 Mar 2019 13:54:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15344218A5 for ; Thu, 21 Mar 2019 13:54:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="v23XHo+Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728247AbfCUNyz (ORCPT ); Thu, 21 Mar 2019 09:54:55 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38048 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728032AbfCUNyz (ORCPT ); Thu, 21 Mar 2019 09:54:55 -0400 Received: by mail-wr1-f66.google.com with SMTP id g12so6691873wrm.5 for ; Thu, 21 Mar 2019 06:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ao61P7vZHn0i1HEZ8w23p6Cldqm5Y1NlQ9UFHDhWey0=; b=v23XHo+Zh8DHY2Z3rHjrFzGHJQF77dmSQzVcIsOjAhEzMwwNpA5q+uOcqpGThew/Sh izqKup+Bk5oG9f30K6Jk++1z7Qol99LWUiO52bVDd+Orn0xUIQbyqfnkS22w2owt2RAy rN7i3hHL+yWfdTKv89Owr1bhYKORVDvwicmVjm8xaT7+0o9AvG6sFZbAKAEXfaJbWStf Bs/XPDbKCZs/FO/xlggq3Db6fZk0hhdbGtsLPJZf3N80SQHfRmOPX0VZZyos1a84taEl b/Df1sAVT/0C8MbQTrLHz652lAWRjyZjWVJjPTnWTwp8QMShNto7DtJHwW0UTgE/bbi1 hHwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ao61P7vZHn0i1HEZ8w23p6Cldqm5Y1NlQ9UFHDhWey0=; b=RBZQSSgaxGU+ctmQfpkdd9BE/wFWhdTdic2GQNh5GsxBk/Jwq54vdOFFVUL64Pym/Z vUs8gfnkpr19wq73qnjVGReou8/61I8IsriGOcTx5Lqdr3srYBU+v+sacutoIelim1mT ESvG6Gtx19+i++HchYj5nEO2wyW+vJozohdMMQ2BBS0udBSYwUM5UU6lbnNwy2LMVVBr XdG6Bu3xr3GyoAfua4SnI9nbRw9uAqQqaZ8CFInBUZt114S1Ynot5teG+TPquA408RJa 3m/eEAyHGdVPc1Ac2osDybgdltkQkhSHXgnOyJ6zuQqlYxIk2vUQyH0Kk78EPwkAzZi3 6PGA== X-Gm-Message-State: APjAAAVotODeCLUhYUuYYmm9X1/bEa24pS4F1BCHCjwXB6Vtst43cRa9 kQRGhdhFoW12zGwTXYicWP5U1w== X-Google-Smtp-Source: APXvYqxxouibuU/g74xnrgQxYsxT927OH2+36nGWt9G3vxD3GDstaJKMMAAZr1aXCJnejelLpr+P1Q== X-Received: by 2002:a5d:4606:: with SMTP id t6mr2637873wrq.43.1553176493949; Thu, 21 Mar 2019 06:54:53 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id w10sm6406627wrn.32.2019.03.21.06.54.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 06:54:53 -0700 (PDT) Date: Thu, 21 Mar 2019 14:44:14 +0100 From: Jiri Pirko To: Andrew Lunn Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, vivien.didelot@gmail.com Subject: Re: [patch net-next 09/11] dsa: move devlink_port_attrs_set() call before register Message-ID: <20190321134414.GG2087@nanopsycho> References: <20190321132019.1426-1-jiri@resnulli.us> <20190321132019.1426-10-jiri@resnulli.us> <20190321134101.GA17655@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321134101.GA17655@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Mar 21, 2019 at 02:41:01PM CET, andrew@lunn.ch wrote: >On Thu, Mar 21, 2019 at 02:20:17PM +0100, Jiri Pirko wrote: >> + switch (dp->type) { >> + case DSA_PORT_TYPE_CPU: >> + flavour = DEVLINK_PORT_FLAVOUR_CPU; >> + break; >> + case DSA_PORT_TYPE_DSA: >> + flavour = DEVLINK_PORT_FLAVOUR_DSA; >> + break; >> + case DSA_PORT_TYPE_USER: /* fall-through */ >> + default: >> + flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL; >> + break; >> + } >> + >> + /* dp->index is used now as port_number. However >> + * CPU ports should have separate numbering >> + * independent from front panel port numbers. >> + */ > >Hi Jiri > >Given the way you have rearranged this code, i think the text above >should now be: > >However CPU ports and DSA ports should have separate numbering. You are right. Will fix in v2. > > Andrew