From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85917C43381 for ; Thu, 21 Mar 2019 14:23:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50333218FF for ; Thu, 21 Mar 2019 14:23:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="xVc3leop" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728160AbfCUOX4 (ORCPT ); Thu, 21 Mar 2019 10:23:56 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:51426 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727922AbfCUOXz (ORCPT ); Thu, 21 Mar 2019 10:23:55 -0400 Received: by mail-wm1-f66.google.com with SMTP id 4so2456335wmf.1 for ; Thu, 21 Mar 2019 07:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7ZUVp54yPDOwwhQQiyc8zpbXweOJ6xkhgZnkaVeLnzo=; b=xVc3leopNXpNS12L14tL6k6VDDWZ1fY4jdJg+7aZr5nwXyou/E8kqpMRTFwAs7tcgI w9nXQ6fLkDwm48wrz0fIQKE1LPM8z8+hMGOxI6v7/xLDvmvUIyP97UVlOGHLYSW8x5UW YgnvIbAPtnCqnhQyorQnuwwDdLsfslvlr2qVHDA2Wnic1d3yveLAJx6lyFrAyxFlTZ4w P8ZdsO75ab/suqkBllbX70Oy+6yejlSUP0RFvd9jgpmqpi15+vZpiKkZRD/Hn9QCT9qC KKjv+hvNw497RR0YbsokuuwXeTJbjrfdu0VuIbACps0MIfOU1tqpTT0lMhxqLKMDZi1N ooxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7ZUVp54yPDOwwhQQiyc8zpbXweOJ6xkhgZnkaVeLnzo=; b=py/YtjbfxTJ2vB0DWxMq6wn6P/HeNHKzyB68v83pYXXCbs32pXgH7kbxv05obo6/cI 0rUB1CWZbYSmCTwCuvc6+EfkrIEA/uJl/cpzHQGWaLzhHu72EYOxHms6AvQE3A9T8zcx g/K5JEEGpCQ/3nk5O7kaH8fA+1VHhKQUjhmVAacmSMfE7lPCLNtwPtFZuvRo7sgdRQ2b S5Cgf3s38fvl7rwa19JLe6qiLhj/47vNLJXXM3s2KqVcWnaNyvUn6pqUxPau5k6nWYly dbrstNYd525kI/i0grE/+XEq80t9lFtg9SCQS0yds5O/0lLZZ5QDFhsLMBWKqVqLJEBy x7eg== X-Gm-Message-State: APjAAAUI7BE0j4Ci8zRk9GQ8ONoOK6cNNgbxtzA+l7U2LCtUV2uu2aob vE3rmFszjVYbMwK7zZbL9BoPLA== X-Google-Smtp-Source: APXvYqy11TnAxYTWBImfpGH2rnBAcBMVdFKeEahjnqQGkzyq8Ih9vVf1kmgFzj6hlAQSERyoY5e63A== X-Received: by 2002:a1c:7517:: with SMTP id o23mr2899164wmc.9.1553178234186; Thu, 21 Mar 2019 07:23:54 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id 13sm5011277wmj.33.2019.03.21.07.23.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 07:23:53 -0700 (PDT) Date: Thu, 21 Mar 2019 15:13:14 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, sbrivio@redhat.com Subject: Re: [PATCH net-next v3 12/12] net: sched: flower: set unlocked flag for flower proto ops Message-ID: <20190321141314.GP2087@nanopsycho> References: <20190321131744.19224-1-vladbu@mellanox.com> <20190321131744.19224-13-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321131744.19224-13-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Mar 21, 2019 at 02:17:44PM CET, vladbu@mellanox.com wrote: >Set TCF_PROTO_OPS_DOIT_UNLOCKED for flower classifier to indicate that its >ops callbacks don't require caller to hold rtnl lock. Don't take rtnl lock >in fl_destroy_filter_work() that is executed on workqueue instead of being >called by cls API and is not affected by setting >TCF_PROTO_OPS_DOIT_UNLOCKED. Rtnl mutex is still manually taken by flower >classifier before calling hardware offloads API that has not been updated >for unlocked execution. > >Signed-off-by: Vlad Buslov >Reviewed-by: Stefano Brivio Acked-by: Jiri Pirko