From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94987C43381 for ; Thu, 21 Mar 2019 22:20:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DD9721917 for ; Thu, 21 Mar 2019 22:20:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727373AbfCUWUA (ORCPT ); Thu, 21 Mar 2019 18:20:00 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:39322 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbfCUWT6 (ORCPT ); Thu, 21 Mar 2019 18:19:58 -0400 Received: by mail-pf1-f193.google.com with SMTP id i17so59920pfo.6 for ; Thu, 21 Mar 2019 15:19:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OVR1nATDVdlt69boRyZg3P5dE1CjPHDE/D1UvNmGOJI=; b=NphMyorYCOVA0epXzDqChBRZZ6G2FGoaABuBWV5p1AkMqgrqVEWdbQutQUTdgt3N9S Sp2+SPiZi8ADGr4RFAFT1YOhoR7JPnuK4wydsequL9ibwatq2z/Ucdj7NP+qs3Hh1VU7 Kp33G7Muhy8mpEha+AOri7+K8gVBWBtQSXs3iZXNH19lvP2Ly8Xxqzx028YYSuuPTj/b mng5KGDtvWQuhZ8a1d5UkZlh8WL+fQ/TVwLlFXy7l1mbN1Ox2sUKaHZqqj/tFsMCe6mH dPY23nxMcfeNw5/jRHKDN1UrHZr4wSz4XEa0DiS6a1nNiYLqKP0ZxsVNGH1ljcy0ikpD zXnA== X-Gm-Message-State: APjAAAW3m13yzd6wV6zrIFKqvw/p1/q+GTfsM+0kFCH5FX8dP6T46RLg 4V7PydB/fBvNdZObrX1zxcUXnwlWZyw= X-Google-Smtp-Source: APXvYqwjcavYibbE2QKlE62VUihgccXAEzSQlyGOTJjCh66yKDW5OvcD+mw/8r/SbVBY4MPSIWOu/g== X-Received: by 2002:a63:4718:: with SMTP id u24mr5641724pga.381.1553206797808; Thu, 21 Mar 2019 15:19:57 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id l7sm16862892pfj.162.2019.03.21.15.19.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 15:19:56 -0700 (PDT) From: Bart Van Assche To: David Miller Cc: netdev@vger.kernel.org, Bart Van Assche , Tom Herbert Subject: [PATCH 3/7] net/core: Document __skb_flow_dissect() flags argument Date: Thu, 21 Mar 2019 15:19:42 -0700 Message-Id: <20190321221946.163803-4-bvanassche@acm.org> X-Mailer: git-send-email 2.20.GIT In-Reply-To: <20190321221946.163803-1-bvanassche@acm.org> References: <20190321221946.163803-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch avoids that the following warning is reported when building with W=1: warning: Function parameter or member 'flags' not described in '__skb_flow_dissect' Cc: Tom Herbert Fixes: cd79a2382aa5 ("flow_dissector: Add flags argument to skb_flow_dissector functions") # v4.3. Signed-off-by: Bart Van Assche --- net/core/flow_dissector.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index bb1a54747d64..b4d581134ef2 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -732,6 +732,8 @@ bool __skb_flow_bpf_dissect(struct bpf_prog *prog, * @proto: protocol for which to get the flow, if @data is NULL use skb->protocol * @nhoff: network header offset, if @data is NULL use skb_network_offset(skb) * @hlen: packet header length, if @data is NULL use skb_headlen(skb) + * @flags: flags that control the dissection process, e.g. + * FLOW_DISSECTOR_F_STOP_AT_L3. * * The function will try to retrieve individual keys into target specified * by flow_dissector from either the skbuff or a raw buffer specified by the -- 2.21.0.155.ge902e9bcae20