From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=eF07=RZ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C32EEC43381
	for <netdev@archiver.kernel.org>; Fri, 22 Mar 2019 14:34:51 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 9B7A821904
	for <netdev@archiver.kernel.org>; Fri, 22 Mar 2019 14:34:51 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729009AbfCVOeu (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 22 Mar 2019 10:34:50 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:52698 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728991AbfCVOes (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 22 Mar 2019 10:34:48 -0400
Received: from localhost (unknown [76.191.116.170])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id AA45D146802B2;
        Fri, 22 Mar 2019 07:34:47 -0700 (PDT)
Date:   Fri, 22 Mar 2019 10:34:46 -0400 (EDT)
Message-Id: <20190322.103446.2296880942068394490.davem@davemloft.net>
To:     hkallweit1@gmail.com
Cc:     nic_swsd@realtek.com, netdev@vger.kernel.org, user.vdr@gmail.com,
        alexander.h.duyck@linux.intel.com
Subject: Re: [PATCH net] r8169: don't read interrupt mask register in
 interrupt handler
From:   David Miller <davem@davemloft.net>
In-Reply-To: <aab8a776-e5bf-67ee-e60c-00bc86ad168b@gmail.com>
References: <aab8a776-e5bf-67ee-e60c-00bc86ad168b@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 Mar 2019 07:34:47 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 21 Mar 2019 21:23:14 +0100

> After the original patch network starts to crash on heavy load.
> It's not fully clear why this additional register read has such side
> effects, but removing it fixes the issue.
> 
> Thanks also to Alex for his contribution and hints.
> 
> [0] https://marc.info/?t=155268170400002&r=1&w=2
> 
> Fixes: e782410ed237 ("r8169: improve spurious interrupt detection")
> Reported-by: VDR User <user.vdr@gmail.com>
> Tested-by: VDR User <user.vdr@gmail.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied and queued up for -stable.