From: Vinod Koul <vkoul@kernel.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [BISECTED, REGRESSION] Broken networking on MIPS/OCTEON EdgeRouter Lite
Date: Fri, 22 Mar 2019 12:15:06 +0530 [thread overview]
Message-ID: <20190322064506.GB5348@vkoul-mobl> (raw)
In-Reply-To: <20190322002125.GD7872@darkstar.musicnaut.iki.fi>
On 22-03-19, 02:21, Aaro Koskinen wrote:
> Hi,
>
> When booting v5.1-rc1 on EdgeRouter Lite (MIPS/OCTEON), with at803x phy
> driver enabled, networking no longer works - I even need to go physically
> power cycle the board before getting networking to work again (otherwise
> bootloader cannot tftp an older working image).
>
> Bisected to:
>
> commit 6d4cd041f0af5b4c8fc742b4a68eac22e420e28c
> Author: Vinod Koul <vkoul@kernel.org>
> Date: Thu Feb 21 15:53:15 2019 +0530
>
> net: phy: at803x: disable delay only for RGMII mode
Hello,
So with cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII
mode") it works for you but not 6d4cd041f0af ("net: phy: at803x: disable
delay only for RGMII mode"). That is bit more weird case :)
So does the ethernet expect RGMII mode or RGMII_ID mode here, looks like
disable delay is expected as well?
Can you point me to the DT node as well..
> Booting v5.1-rc1 with this commit reverted makes networking to work
> fine again.
--
~Vinod
next prev parent reply other threads:[~2019-03-22 6:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 0:21 [BISECTED, REGRESSION] Broken networking on MIPS/OCTEON EdgeRouter Lite Aaro Koskinen
2019-03-22 6:45 ` Vinod Koul [this message]
2019-03-22 20:50 ` Aaro Koskinen
2019-03-22 21:25 ` Andrew Lunn
2019-03-22 21:41 ` Aaro Koskinen
2019-03-24 20:17 ` Andrew Lunn
2019-03-25 19:30 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322064506.GB5348@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox