From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966CFC43381 for ; Fri, 22 Mar 2019 13:49:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6363B218D4 for ; Fri, 22 Mar 2019 13:49:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="anit07/x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728555AbfCVNte (ORCPT ); Fri, 22 Mar 2019 09:49:34 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35790 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728005AbfCVNtd (ORCPT ); Fri, 22 Mar 2019 09:49:33 -0400 Received: by mail-wr1-f66.google.com with SMTP id w1so2466855wrp.2 for ; Fri, 22 Mar 2019 06:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q38DYEqJeOnUOCeEoz1NDlPIen4YIQTRVv/+4jCZEsU=; b=anit07/xbzWpBiA8odG7LfkSVW9S6cafGCqDsMnyuVVw+EvjzZeBqT7Mlm8JbqAzca SNXeOFr0vK9uo90fBDvlr7B7nlclU3MO0auIzujYNAKuWbK08xTgJhrShHbKwS9CO7w4 sp29C3Uwkjddrz0vQ1nReu5l9I9cfSqaf4oqAb55MRQDHqSumFLF7sS+o+xrZAPO9dyl KOHalEwmlWEe5EQ61av0OkQsg7dsqu4Zny5ThmGCvLs2DTCB9fsMKfwiEIj/dQGlmtV9 wMFu1AZ8Yhz6b8NoQhrwCToys/nfIGUhlkaDJUAKqbfOCqOEP1T6ccI4TE4QvFDZY8yw qgvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q38DYEqJeOnUOCeEoz1NDlPIen4YIQTRVv/+4jCZEsU=; b=D4bmp0WphJtTpYS607uSyvV9gDZfNeJQCt0zt8LZJlZGtz8R8wJZ6DCJdrPTxBQMTy Eg8vTKOAlE7TCDYzQ/+3ltHceLL0XjUmzHIyxqdjDpqTOaY1SI5iEJZvbKvV+vG4jalA ztvffWzvC3jTFMf3azbc7ZxHOUXk8A+DX7gQb7FujhGD4UoVt5dnfBEkfBV6kvEKr8oT BQKGIaSKnVP/RHRqbTFvEWucRkTgUJ4XGajDZd6zNdZ3eSe4nzIKvzE6FrURt2HTARQ+ OspUyaNn0Bt/2/RU/ktqQ3m3+IP+lchS+BkLDmkMuXuKMOTxXvBbx1t5nADMXdGcZ+eO JOQg== X-Gm-Message-State: APjAAAUuo2cfDrYluSaUfHB3xcnW2AKlXmyWkP6ES6b0YLusDa03VqSC UGadxv35j3ydFUpzjufMTDaIPQ== X-Google-Smtp-Source: APXvYqy4J56zliIYfdW9HdM2DdW+FLMTV2pPW3bU0gEMPrh+QhPzhFCc4S2vFXxn3pfuqsuXRQnmfQ== X-Received: by 2002:a5d:5401:: with SMTP id g1mr6817054wrv.70.1553262572024; Fri, 22 Mar 2019 06:49:32 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id b134sm17113730wmd.26.2019.03.22.06.49.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 06:49:31 -0700 (PDT) Date: Fri, 22 Mar 2019 14:38:50 +0100 From: Jiri Pirko To: Vasundhara Volam Cc: Netdev , David Miller , mlxsw@mellanox.com, idosch@mellanox.com, Jakub Kicinski , f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [patch net-next 02/11] bnxt: add missing net/devlink.h include Message-ID: <20190322133850.GC2211@nanopsycho> References: <20190321132019.1426-1-jiri@resnulli.us> <20190321132019.1426-3-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Mar 22, 2019 at 10:16:34AM CET, vasundhara-v.volam@broadcom.com wrote: >On Thu, Mar 21, 2019 at 6:50 PM Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> devlink functions are in use, so include the related header file. >> >> Signed-off-by: Jiri Pirko >> --- >> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c >> index e1feb97bcd81..ecb328ee8f5c 100644 >> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c >> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c >> @@ -9,6 +9,7 @@ >> >> #include >> #include >> +#include >Jiri, >This net/devlink.h file is already included in bnxt.h file which is >included in bnxt_devlink.c. >Do you face any issues with existing code while compiling or testing? It is better to include directly, not to rely on some header to include it. > >Thanks, >Vasundhara > > >> #include "bnxt_hsi.h" >> #include "bnxt.h" >> #include "bnxt_vfr.h" >> -- >> 2.17.2 >>