From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22232C43381 for ; Fri, 22 Mar 2019 16:14:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA825218A2 for ; Fri, 22 Mar 2019 16:14:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ditwB6Zo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729201AbfCVQO2 (ORCPT ); Fri, 22 Mar 2019 12:14:28 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:34973 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727169AbfCVQO2 (ORCPT ); Fri, 22 Mar 2019 12:14:28 -0400 Received: by mail-pg1-f196.google.com with SMTP id g8so1857563pgf.2 for ; Fri, 22 Mar 2019 09:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jILYf9uMVEE9XAjvTqXuWyG1SAKpDrAHFuyNu3OSJcI=; b=ditwB6ZozL5GTZ2DQFpcvtRcG/e5IUm94iBSVugSnFpppH28CavYzrAJdNEeVYaGih 0b8MNWZLIHkOLIdq7m0bVcc/YMAgML+PPsOhCkQEuhJFShFZZKiXIpXdZbrd4HEr7rkX 6rTRPCcnQtUZ51EbQvL6h6S2iF0ItTa+pV0LXZOJ+Ktjwvim5+OoNA6ZMuJSKKc0pcMe +/no6QlFpP4qDXSLOf1DG2ofFDjmgdlfLCxOd6CCgRzPC7f7fvhc/oDyZT1A02kBTIlF 5Uh1P3EkbPKPYFCSyPmqyp8hKNz30DudTHrWl1ynUJAwALtLvtEzK6UrNEr78Z+asyTC Lg0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jILYf9uMVEE9XAjvTqXuWyG1SAKpDrAHFuyNu3OSJcI=; b=gPjvh6pCPopk1Q4wmxSKcMAdw6gWxArXZ439fXKzt8ndxNEk0AtSjgE7HkED5FKxCr mfoSbxN0vx7T6a/z2iT9+MVrE0CjLiIrFLbM5CdInrJ+OGtTmt0ZQOskcaec7GBLjaIN Ni69DZy+L9ZS6vR/6w8b12m/UYrMNTgV0m4b5A+gRMVJ3cr5qy9A3geWIMVvvzfRG1T8 9E248yxFJDI5ljqK8d6dlUAozmkns5FEEGK7ldbDGMM13gYybERMvx52KFLZvavpJ/NC 7mphHUfd+QDS1mgKZ8iVz0PLGG+PdOwL8kylE2HgN6ECN27UAQqcqaOZb7vwoIaWraQi dhZA== X-Gm-Message-State: APjAAAXA3wHwFOvKfJXvlQaPfeaosjz8H72AetRSVFwlzkeM0MbuFiBq v/bkm1rUGL+eYD4wx4N8xFQ= X-Google-Smtp-Source: APXvYqxfjT3O511HGVPhhOJLgu6cryXF/lKUm1stIJZKN7cOLeHzJJlCgoKB7vUFgEN/KQEAGtptbA== X-Received: by 2002:a65:64c4:: with SMTP id t4mr9751911pgv.152.1553271267266; Fri, 22 Mar 2019 09:14:27 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:200::e4e7]) by smtp.gmail.com with ESMTPSA id u15sm13525944pfm.163.2019.03.22.09.14.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Mar 2019 09:14:26 -0700 (PDT) Date: Fri, 22 Mar 2019 09:14:25 -0700 From: Alexei Starovoitov To: David Ahern Cc: davem@davemloft.net, netdev@vger.kernel.org, David Ahern Subject: Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file Message-ID: <20190322161423.anyrhc3i5wtbuamp@ast-mbp.dhcp.thefacebook.com> References: <20190322130609.11655-1-dsahern@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190322130609.11655-1-dsahern@kernel.org> User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 22, 2019 at 06:06:09AM -0700, David Ahern wrote: > From: David Ahern > > The number of stubs is growing and has nothing to do with addrconf. > Move the definition of the stubs to a separate header file and update > users. In the move, drop the vxlan specific comment before ipv6_stub. > > Code move only; no functional change intended. > > Signed-off-by: David Ahern nack. why this code churn? I very much prefer to disallow ipv6 as a module.