From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7A6C43381 for ; Fri, 22 Mar 2019 17:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B995C2190A for ; Fri, 22 Mar 2019 17:04:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d3URzYoF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728519AbfCVREk (ORCPT ); Fri, 22 Mar 2019 13:04:40 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38934 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727706AbfCVREk (ORCPT ); Fri, 22 Mar 2019 13:04:40 -0400 Received: by mail-pg1-f193.google.com with SMTP id h8so1929786pgp.6 for ; Fri, 22 Mar 2019 10:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8Hvb5SC0tX/lMh4rr/edh+BNYaXD1W+lJsNb63dONEs=; b=d3URzYoFIo/7+FrvLJXoQvrO0StCTL4gm5OEd/TGkHWCrX4LsP0IZrp4UFEvLZPznq nBDo9oX7uTN/dzuUkVFjQI705INjh6aKeamuzhwr13i6KEFJE8o9C9lFNf/ql5q5hGb0 7HWikzqB8ilU3mgt+kHLsQle50DoF34ARjsV9Im8lSQnmIraGQ84qx1rNzEz0hwlaSZN RekBT6cSgCY5yWWN1rcsvS8uHdfo1EtwIref3uM8+6t6sFCWlOvbD3FJJCsWotcoQ/C1 Qy549tIqjWhGs6Tval05vbH2GPe4FLdcDr87ZM6HP2A2tr4yc9cu2u2nh3TM239QCsQ5 AlPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8Hvb5SC0tX/lMh4rr/edh+BNYaXD1W+lJsNb63dONEs=; b=PRTfjmesRWF6ozMd/1I+O7xlHfy9SOjH5nk3zOQ50YB/aJR4PbT0/4TFFuDtekocEW YYsdwzoB36GcAi3H6Bh6QO3XCmnT9AyHzCOnzxl6clyilM0F5CO5GQukY2UZOBDMbY/b 2OGAHs6WvGTvO4phmASuIDAMifXv69xPVS+ToBEXEstlzuFNWh4KmqVH52nZAqF0i/fK h6mpz/kUqKQ9Akwxk6IjcV7zCIob488vabcPi4rELDvIdBGBx4LsxZ/fhhsf8BasKdbp +VL+rrb443az+vJuffarDpXrIxoro8FUiPfnGBvcnt/DGzuTTG3fua7JiuHZyfBKr4Qc G5jQ== X-Gm-Message-State: APjAAAXCPEh8mEHMTTZ8ajLzBtbQeGFis7PSRheQVQ4KFq23pUkow6bI jGKkL77VbMCemuWsjNpm2Cb7U7hq X-Google-Smtp-Source: APXvYqyhYfbPU0/8s0wyDQgLhtnoQx8/62NZBkiv56RZc3+YHRtM2OYM4oXaRkpjBnUiokCsT7ZPlQ== X-Received: by 2002:a17:902:a98b:: with SMTP id bh11mr10552570plb.63.1553274279261; Fri, 22 Mar 2019 10:04:39 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:200::e4e7]) by smtp.gmail.com with ESMTPSA id z189sm12165575pfb.146.2019.03.22.10.04.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Mar 2019 10:04:38 -0700 (PDT) Date: Fri, 22 Mar 2019 10:04:37 -0700 From: Alexei Starovoitov To: David Ahern Cc: David Ahern , davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file Message-ID: <20190322170435.abiwibew67527lde@ast-mbp.dhcp.thefacebook.com> References: <20190322130609.11655-1-dsahern@kernel.org> <20190322161423.anyrhc3i5wtbuamp@ast-mbp.dhcp.thefacebook.com> <57a656dc-5be4-830a-2a54-550d0a62a475@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57a656dc-5be4-830a-2a54-550d0a62a475@gmail.com> User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 22, 2019 at 05:17:52PM +0100, David Ahern wrote: > On 3/22/19 5:14 PM, Alexei Starovoitov wrote: > > On Fri, Mar 22, 2019 at 06:06:09AM -0700, David Ahern wrote: > >> From: David Ahern > >> > >> The number of stubs is growing and has nothing to do with addrconf. > >> Move the definition of the stubs to a separate header file and update > >> users. In the move, drop the vxlan specific comment before ipv6_stub. > >> > >> Code move only; no functional change intended. > >> > >> Signed-off-by: David Ahern > > > > nack. > > why this code churn? > > This is a prep patch for nexthops as separate objects. I will be adding > 4 more functions to the stubs, and I hit a bit of a header nightmare > with it in addrconf.h. please do not. I see no value in splitting nexthops either.