From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=eF07=RZ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,
	URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4F97AC43381
	for <netdev@archiver.kernel.org>; Fri, 22 Mar 2019 20:47:37 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 1E86521925
	for <netdev@archiver.kernel.org>; Fri, 22 Mar 2019 20:47:37 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="A8RuCR8v"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727797AbfCVUrg (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 22 Mar 2019 16:47:36 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:35426 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727426AbfCVUrf (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 22 Mar 2019 16:47:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=s1+6chgvjyi+3CAZKpkofMqyYiMn1iMKd1j6bFqlLlY=; b=A8RuCR8vUx/CCOrQhiaJ6tAp9D
        sajmm51jJ3R4pfwm5gWv0ILCB7bBD3xlYNRj8hcL/QFiEaPmxYy62Q+9Xy9VJH3amrzhJYrAsnFsX
        SZRP+P6F30jX10e9CdyL0MZ5Pzgrjbll3vehopxMOnq7aS/hym2787cdU+VRpVU+wbLA=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1h7R4d-00055S-D7; Fri, 22 Mar 2019 21:47:31 +0100
Date:   Fri, 22 Mar 2019 21:47:31 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Jiri Pirko <jiri@resnulli.us>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com,
        idosch@mellanox.com, jakub.kicinski@netronome.com,
        f.fainelli@gmail.com, vivien.didelot@gmail.com
Subject: Re: [patch net-next v2 09/15] dsa: move devlink_port_attrs_set()
 call before register
Message-ID: <20190322204731.GD16623@lunn.ch>
References: <20190322165636.1725-1-jiri@resnulli.us>
 <20190322165636.1725-10-jiri@resnulli.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190322165636.1725-10-jiri@resnulli.us>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, Mar 22, 2019 at 05:56:30PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
> 
> Since attrs are static during the existence of devlink port, set the
> before registration of the port.
> 
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew