From: David Miller <davem@davemloft.net>
To: wen.yang99@zte.com.cn
Cc: linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn,
w-kwok2@ti.com, m-karicheri2@ti.com, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] net: ethernet: ti: fix possible object reference leak
Date: Sat, 23 Mar 2019 21:22:02 -0400 (EDT) [thread overview]
Message-ID: <20190323.212202.1802065146621678109.davem@davemloft.net> (raw)
In-Reply-To: <1553223849-7143-3-git-send-email-wen.yang99@zte.com.cn>
From: Wen Yang <wen.yang99@zte.com.cn>
Date: Fri, 22 Mar 2019 11:04:09 +0800
> The call to of_get_child_by_name returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
>
> Detected by coccinelle with the following warnings:
> ./drivers/net/ethernet/ti/netcp_ethss.c:3661:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.
> ./drivers/net/ethernet/ti/netcp_ethss.c:3665:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.
>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Applied.
next prev parent reply other threads:[~2019-03-24 1:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 3:04 [PATCH 1/3] net: xilinx: fix possible object reference leak Wen Yang
2019-03-22 3:04 ` [PATCH 2/3] net: ibm: " Wen Yang
2019-03-24 1:21 ` David Miller
2019-03-22 3:04 ` [PATCH 3/3] net: ethernet: ti: " Wen Yang
2019-03-24 1:22 ` David Miller [this message]
2019-04-05 8:27 ` [PATCH 3/3] " Markus Elfring
2019-03-24 1:21 ` [PATCH 1/3] net: xilinx: " David Miller
2019-04-05 7:54 ` Markus Elfring
2019-04-05 8:13 ` Dan Carpenter
2019-04-05 9:18 ` [1/3] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323.212202.1802065146621678109.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=w-kwok2@ti.com \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).