From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE05C43381 for ; Sun, 24 Mar 2019 03:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3625D20685 for ; Sun, 24 Mar 2019 03:04:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="ejJVX9aN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbfCXDEL (ORCPT ); Sat, 23 Mar 2019 23:04:11 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:36434 "EHLO mail-pf1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727702AbfCXDEK (ORCPT ); Sat, 23 Mar 2019 23:04:10 -0400 Received: by mail-pf1-f178.google.com with SMTP id p10so4059390pff.3 for ; Sat, 23 Mar 2019 20:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=Da7QG/Ps6jVd21WVIVJafoP+w9Z0MYyF+6EDJB/jY68=; b=ejJVX9aNs1ncor6PdhtmRXMq7jxgm0ISNZc7r7VfuOovciEfWyu6D5+g3j+e/OC4So xXTp0vBeg6zQQ7q8a8bBKfzwxxSplaAKVovzBohSgWSatpRWTGyB9nVECcpn2roCnblI DskwU2v2FtpL4uQDHXCvY0hV+7CboJ04/Z0Krvz+ekFTgI5WihtQsdII13PmI/wmSNYr n3mT18l77I1rcjR3Mw8CK4OT6Z0zErEOkNviKU3oGRsfV78y6wuafOgtzE/fKu79EpUE aKNEdCYbA6SrEioCV77cZiaIY9pQDCSL89ZEjVtEWogjPxXOpVBSwTFGVYZuXiGfnnMl jGLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=Da7QG/Ps6jVd21WVIVJafoP+w9Z0MYyF+6EDJB/jY68=; b=Px1VQEUWn2Bk0EABksWgCTbRoCDCVVBaCJDSOg3civgF/txIT2EHbYhIk0nq51wb8b JRUGYxbzLyaUSpKRX5iFOKDsdtZ4diZEvbkYrXNc9JNVpdS9lWHLXGlaJmLN+3PWMmFs 7kI6LydXoCHQl7/uC3BPN+7GUfOu8OGTh1jyOcRTx+QlXwXe0qQziJ27MEOdbiOW1tlj eL/sjAsyFdKllBYg/cr4nmBZ9vwmEUGl9F+9yqftUxAJzSofAGH/rubiEIkzn3d3Vr+5 d2oA6HRNWN8HzUA2lcU9UcCqbl+H6Aec2Bld67Wh0+2fJvVkil5wOiK4vgxgwQ9KbCQA OQ8Q== X-Gm-Message-State: APjAAAWCHRChEdqXzq11axXGYXNb82jUTsydRUkJr4m11JVqPDrEqsxT 1RHpg3LY9dy5/Z3ifl/cTbkzag== X-Google-Smtp-Source: APXvYqzCBWmT7DuxmIwLUVNKRhCAG0yJkfTy31FU1eIEBLIjP8vQLyB5m1+gkyls9uKrE06RijsqHQ== X-Received: by 2002:a65:624c:: with SMTP id q12mr16207609pgv.75.1553396650233; Sat, 23 Mar 2019 20:04:10 -0700 (PDT) Received: from cakuba.netronome.com ([2601:646:8e00:1b7a::2]) by smtp.gmail.com with ESMTPSA id s78sm17689885pfa.134.2019.03.23.20.04.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Mar 2019 20:04:10 -0700 (PDT) Date: Sat, 23 Mar 2019 20:04:05 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [patch net-next v2 11/15] nfp: move devlink port type set after netdev registration Message-ID: <20190323200405.4a334368@cakuba.netronome.com> In-Reply-To: <20190323224750.GC2327@nanopsycho> References: <20190322165636.1725-1-jiri@resnulli.us> <20190322165636.1725-12-jiri@resnulli.us> <20190323133102.60fceb6e@cakuba.netronome.com> <20190323224750.GC2327@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 23 Mar 2019 23:47:50 +0100, Jiri Pirko wrote: > >type setting. I'd rather those calls happened on fully initialized > >netdev (and port), could you perhaps just take this patch into the > > I don't get it, you are commenting cleanup part. On init, the type set > happens on fully initialized devlink_port and netdev. I'm talking about internal nfp API calls, nfp_app_vnic_init() and nfp_app_vnic_clean() should be called while vNIC is completely initialized and registered from stack's PoV. netdev, and devlink port fully initialized and set up. I don't think it matters much, just an imperfection.