From: David Miller <davem@davemloft.net>
To: Markus.Amend@telekom.de
Cc: gerrit@erg.abdn.ac.uk, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, dccp@vger.kernel.org
Subject: Re: [PATCH] net: dccp: Checksum verification considering skb->ip_summed
Date: Sun, 24 Mar 2019 20:13:57 -0400 (EDT) [thread overview]
Message-ID: <20190324.201357.1580092867848179795.davem@davemloft.net> (raw)
In-Reply-To: <FRAPR01MB11703F861DE24373440FD1C0FA430@FRAPR01MB1170.DEUPRD01.PROD.OUTLOOK.DE>
From: <Markus.Amend@telekom.de>
Date: Fri, 22 Mar 2019 14:34:58 +0000
> @@ -786,7 +787,8 @@ static int dccp_v4_rcv(struct sk_buff *skb)
>
> iph = ip_hdr(skb);
> /* Step 1: If header checksum is incorrect, drop packet and return */
> - if (dccp_v4_csum_finish(skb, iph->saddr, iph->daddr)) {
> + if (__skb_checksum_validate(skb, IPPROTO_DCCP,
> + true, false, 0, inet_compute_pseudo)) {
The arguments on the second and subsequent lines of a function call must
begin precisely at the first column after the openning parenthesis of
the first line of the function call.
You must use the appropriate number of TAB, then SPACE, characters
necessary to achieve this.
prev parent reply other threads:[~2019-03-25 0:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 14:34 [PATCH] net: dccp: Checksum verification considering skb->ip_summed Markus.Amend
2019-03-25 0:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324.201357.1580092867848179795.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Markus.Amend@telekom.de \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).